Folder renaming failing despite it being supported by rope

[mrtolkien]

Issue Type: Bug

Renaming packages, both from the symbol or from the folder name, does not work despite being fully supported in rope.

Test setup:

PACKAGE
├── __init__.py (import SUBPACKAGE)
└── SUBPACKAGE
    └── __init__.py (print("hello"))

Trying to rename the SUBPACKAGE symbol in PACKAGE/__init__.py does not work and creates this error log:

Refactor failed. Unknown Change
[<FrameSummary file /home/tolki/.vscode-server/extensions/ms-python.python-2021.4.765268190/pythonFiles/refactor.py, line 380 in watch>, <FrameSummary file /home/tolki/.vscode-server/extensions/ms-python.python-2021.4.765268190/pythonFiles/refactor.py, line 346 in _process_request>, <FrameSummary file /home/tolki/.vscode-server/extensions/ms-python.python-2021.4.765268190/pythonFiles/refactor.py, line 259 in _rename>, <FrameSummary file /home/tolki/.vscode-server/extensions/ms-python.python-2021.4.765268190/pythonFiles/refactor.py, line 128 in refactor>, <FrameSummary file /home/tolki/.vscode-server/extensions/ms-python.python-2021.4.765268190/pythonFiles/refactor.py, line 163 in onRefactor>]

Here is the equivalent rope code that works:

from rope.base.project import Project
from rope.refactor.rename import Rename

project = Project('.')

module = project.find_module("PACKAGE.SUBPACKAGE")

changes = Rename(project, module).get_changes("SUBPACKAGE_RENAMED")

project.do(changes)

VS Code version: Code 1.55.2 (3c4e3df9e89829dce27b7b5c24508306b151f30d, 2021-04-13T09:35:57.887Z)
OS version: Windows_NT x64 10.0.19042
Remote OS version: Linux x64 5.4.72-microsoft-standard-WSL2

System Info

Item	Value
CPUs	AMD Ryzen 7 5800X 8-Core Processor (16 x 3793)
GPU Status	2d_canvas: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on oop_rasterization: enabled opengl: enabled_on protected_video_decode: unavailable_off rasterization: enabled skia_renderer: enabled_on video_decode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled
Load (avg)	undefined
Memory (System)	31.94GB (17.16GB free)
Process Argv	--crash-reporter-id ea62742e-2d7a-4234-b611-aca124c7078b
Screen Reader	no
VM	0%

Item	Value
Remote	WSL: Ubuntu-20.04
OS	Linux x64 5.4.72-microsoft-standard-WSL2
CPUs	AMD Ryzen 7 5800X 8-Core Processor (16 x 3792)
Memory (System)	25.01GB (19.83GB free)
VM	0%

Extensions (13)

Extension	Author (truncated)	Version
better-comments	aar	2.1.0
bracket-pair-colorizer	Coe	1.0.61
auto-close-tag	for	0.5.10
remote-containers	ms-	0.166.1
remote-wsl	ms-	0.54.6
material-icon-theme	PKi	4.6.0
path-intellisense	chr	2.3.0
vscode-markdownlint	Dav	0.40.3
prettier-vscode	esb	6.3.2
vscode-docker	ms-	1.12.1
python	ms-	2021.4.765268190
vscode-pylance	ms-	2021.4.1
jupyter	ms-	2021.5.745244803

A/B Experiments

vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspyt653:30270858
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstry244:30276681
pythonvsdeb440:30248342
pythonvsded773:30248341
pythonvspyt875:30259475
pythonvsnew554:30281908
pythontb:30283811
openwslfolder:30282073
vspre833cf:30267465
pythonptprofiler:30281270
vshan820:30276952
pythondataviewer:30285071
vscus158cf:30286554

[karthiknadig]

@mrtolkien Since we are planning on deprecating the old Jedi for the newer JediLSP language server, we are prioritizing fixing this in the newer LS. However, if you can provide a PR fixing the old Jedi LS we are happy to take it. The fix should mostly be contained in this file: https://github.com/microsoft/vscode-python/blob/main/pythonFiles/refactor.py

The upstream issue with the underlying LS library has been fixed openlawlibrary/pygls#176. One this change is picked up by jedi-language-server pappasam/jedi-language-server#134 we should be able to update this in the extension.

[kimadeline]

rope is being removed in the 2021.10 release (#17225), closing this issue as stale. Refactoring is now provided (via a lightbulb action) by the language server (either Jedi or Pylance).