Remove old code (#16877)

* Remove ctags (#16066)

* Remove rope (#16064)

* Remove default pylint when using jedi (#16074)

* Remove default pylint when using jedi

* Remove pylint minimal checkers

* Remove more pylint config

* Restore missed configuration file names

* More linting clean up

* Fix tests

* Remove unused files and update branch (#16128)

* Add the 'security-events' permission to the CodeQL workflow (#16071)

* Delete misc files we don't need anymore

Co-authored-by: Brett Cannon <[email protected]>

* Rebase with main

* Update news items.

* Remove unused telemetry

* Test build workflow

* Remove ropeproject from repo settings

* Remove workspace symbols

* Update .eslintignore

* Remove testing of build workflow

* Remove unused symbolProvider.py

Co-authored-by: Brett Cannon <[email protected]>
Co-authored-by: Kim-Adeline Miguel <[email protected]>

Author: 3 people

.eslintignore

@@ -191,14 +191,6 @@ src/test/application/misc/joinMailingListPrompt.unit.test.ts
 
 src/test/performance/load.perf.test.ts
 
-src/test/refactor/extension.refactor.extract.method.test.ts
-src/test/refactor/extension.refactor.extract.var.test.ts
-
-src/test/workspaceSymbols/provider.unit.test.ts
-src/test/workspaceSymbols/common.ts
-src/test/workspaceSymbols/main.unit.test.ts
-src/test/workspaceSymbols/generator.unit.test.ts
-
 src/client/interpreter/configuration/interpreterSelector/commands/base.ts
 src/client/interpreter/configuration/interpreterSelector/commands/resetInterpreter.ts
 src/client/interpreter/configuration/interpreterSelector/commands/setShebangInterpreter.ts
@@ -223,27 +215,16 @@ src/client/terminals/codeExecution/terminalCodeExecution.ts
 src/client/terminals/codeExecution/codeExecutionManager.ts
 src/client/terminals/codeExecution/djangoContext.ts
 
-src/client/providers/objectDefinitionProvider.ts
 src/client/providers/serviceRegistry.ts
-src/client/providers/symbolProvider.ts
 src/client/providers/completionSource.ts
-src/client/providers/renameProvider.ts
-src/client/providers/hoverProvider.ts
-src/client/providers/itemInfoSource.ts
 src/client/providers/formatProvider.ts
 src/client/providers/importSortProvider.ts
 src/client/providers/replProvider.ts
 src/client/providers/codeActionProvider/main.ts
 src/client/providers/codeActionProvider/launchJsonCodeActionProvider.ts
 src/client/providers/codeActionProvider/pythonCodeActionProvider.ts
-src/client/providers/docStringFoldingProvider.ts
 src/client/providers/linterProvider.ts
-src/client/providers/simpleRefactorProvider.ts
-src/client/providers/completionProvider.ts
-src/client/providers/definitionProvider.ts
-src/client/providers/referenceProvider.ts
 src/client/providers/terminalProvider.ts
-src/client/providers/signatureProvider.ts
 
 src/client/activation/languageServer/manager.ts
 src/client/activation/languageServer/languageServerExtension.ts
@@ -464,9 +445,3 @@ src/client/application/diagnostics/commands/factory.ts
 src/client/application/diagnostics/commands/execVSCCommand.ts
 src/client/application/diagnostics/commands/launchBrowser.ts
 
-src/client/refactor/proxy.ts
-src/client/workspaceSymbols/main.ts
-src/client/workspaceSymbols/generator.ts
-src/client/workspaceSymbols/parser.ts
-src/client/workspaceSymbols/provider.ts
-

.github/test_plan.md

@@ -141,36 +141,15 @@ SPAM='hello ${WHO}'
     -   [ ] Create a virtual environment
     -   [ ] Install `requests` into the virtual environment
 
-#### Pylint/default linting
-
-[Prompting to install Pylint is covered under `Environments` above]
-
-For testing the disablement of the default linting rules for Pylint:
-
-```ini
-# pylintrc
-[MESSAGES CONTROL]
-enable=bad-names
-```
-
-```python3
-# example.py
-foo = 42  # Marked as a disallowed name.
-```
-
--   [ ] Installation via the prompt installs Pylint as appropriate
-    -   [ ] Uses `--user` for system-install of Python
-    -   [ ] Installs into a virtual environment environment directly
--   [ ] Pylint works
--   [ ] The existence of a `pylintrc` file turns off the default rules
-
-#### Other linters
+#### Linting
 
 **Note**:
 
 -   You can use the `Run Linting` command to run a newly installed linter
 -   When the extension installs a new linter, it turns off all other linters
 
+-   [ ] pylint works
+    -   [ ] `Select linter` lists the linter and installs it if necessary
 -   [ ] flake8 works
     -   [ ] `Select linter` lists the linter and installs it if necessary
 -   [ ] mypy works
@@ -223,14 +202,6 @@ def foo():pass
     -   [ ] yapf
 -   [ ] `"editor.formatOnType": true` works and has expected results
 
-#### [Refactoring](https://code.visualstudio.com/docs/python/editing#_refactoring)
-
--   [ ] [`Extract Variable`](https://code.visualstudio.com/docs/python/editing#_extract-variable) works
-    -   [ ] You are prompted to install `rope` if it is not already available
--   [ ] [`Extract method`](https://code.visualstudio.com/docs/python/editing#_extract-method) works
-    -   [ ] You are prompted to install `rope` if it is not already available
--   [ ] [`Sort Imports`](https://code.visualstudio.com/docs/python/editing#_sort-imports) works
-
 ### [Debugging](https://code.visualstudio.com/docs/python/debugging)
 
 -   [ ] [Configurations](https://code.visualstudio.com/docs/python/debugging#_debugging-specific-app-types) work (see [`package.json`](https://github.com/Microsoft/vscode-python/blob/main/package.json) and the `"configurationSnippets"` section for all of the possible configurations)

.vscode/settings.json

@@ -12,7 +12,6 @@
         ".vscode-test": false,
         ".vscode test": false,
         "**/.mypy_cache/**": true,
-        "**/.ropeproject/**": true
     },
     "search.exclude": {
         "out": true, // set this to false to include "out" folder in search results
@@ -45,7 +44,6 @@
     "typescript.tsdk": "./node_modules/typescript/lib", // we want to use the TS server from our node_modules folder to control its version
     "python.linting.enabled": false,
     "python.testing.promptToConfigure": false,
-    "python.workspaceSymbols.enabled": false,
     "python.formatting.provider": "black",
     "typescript.preferences.quoteStyle": "single",
     "javascript.preferences.quoteStyle": "single",

build/conda-functional-requirements.txt

@@ -11,7 +11,6 @@ pycodestyle
 pydocstyle
 nose
 pytest==4.6.9 # Last version of pytest with Python 2.7 support
-rope
 fastapi ; python_version>='3.6'
 uvicorn ; python_version>='3.6'
 flask

build/test-requirements.txt

@@ -10,7 +10,6 @@ pycodestyle
 pydocstyle
 prospector ; python_version > '2.7'
 pytest<6 ; python_version > '2.7'  # Tests currently fail against pytest 6.
-rope
 flask
 fastapi ; python_version > '2.7'
 uvicorn ; python_version > '2.7'

news/3 Code Health/10440.md

@@ -0,0 +1 @@
+Remove support for `rope`. Refactoring now supported via language servers.

news/3 Code Health/13321.md

@@ -0,0 +1 @@
+Remove `pylintMinimalCheckers` setting. Syntax errors now reported via language servers.

news/3 Code Health/16063.md

@@ -0,0 +1 @@
+Remove `ctags` support. Workspace symbols now supported via language servers.

package.json

@@ -67,7 +67,6 @@
         "onCommand:python.viewOutput",
         "onCommand:python.execSelectionInTerminal",
         "onCommand:python.execSelectionInDjangoShell",
-        "onCommand:python.buildWorkspaceSymbols",
         "onCommand:python.startREPL",
         "onCommand:python.goToPythonObject",
         "onCommand:python.reportIssue",
@@ -308,11 +307,6 @@
                 "command": "python.analysis.restartLanguageServer",
                 "title": "%python.command.python.analysis.restartLanguageServer.title%"
             },
-            {
-                "category": "Python",
-                "command": "python.buildWorkspaceSymbols",
-                "title": "%python.command.python.buildWorkspaceSymbols.title%"
-            },
             {
                 "category": "Python",
                 "command": "python.clearPersistentStorage",
@@ -380,16 +374,6 @@
                 "command": "python.launchTensorBoard",
                 "title": "%python.command.python.launchTensorBoard.title%"
             },
-            {
-                "category": "Python Refactor",
-                "command": "python.refactorExtractMethod",
-                "title": "%python.command.python.refactorExtractMethod.title%"
-            },
-            {
-                "category": "Python Refactor",
-                "command": "python.refactorExtractVariable",
-                "title": "%python.command.python.refactorExtractVariable.title%"
-            },
             {
                 "category": "Python",
                 "command": "python.refreshTensorBoard",
@@ -1275,47 +1259,6 @@
                     "description": "Path to folder with a list of Virtual Environments (e.g. ~/.pyenv, ~/Envs, ~/.virtualenvs).",
                     "scope": "machine",
                     "type": "string"
-                },
-                "python.workspaceSymbols.ctagsPath": {
-                    "default": "ctags",
-                    "description": "Fully qualified path to the ctags executable (else leave as ctags, assuming it is in current path).",
-                    "scope": "resource",
-                    "type": "string"
-                },
-                "python.workspaceSymbols.enabled": {
-                    "default": false,
-                    "description": "Set to 'true' to enable ctags to provide Workspace Symbols.",
-                    "scope": "resource",
-                    "type": "boolean"
-                },
-                "python.workspaceSymbols.exclusionPatterns": {
-                    "default": [
-                        "**/site-packages/**"
-                    ],
-                    "description": "Pattern used to exclude files and folders from ctags See http://ctags.sourceforge.net/ctags.html.",
-                    "items": {
-                        "type": "string"
-                    },
-                    "scope": "resource",
-                    "type": "array"
-                },
-                "python.workspaceSymbols.rebuildOnFileSave": {
-                    "default": true,
-                    "description": "Whether to re-build the tags file on when changes made to python files are saved.",
-                    "scope": "resource",
-                    "type": "boolean"
-                },
-                "python.workspaceSymbols.rebuildOnStart": {
-                    "default": true,
-                    "description": "Whether to re-build the tags file on start (defaults to true).",
-                    "scope": "resource",
-                    "type": "boolean"
-                },
-                "python.workspaceSymbols.tagFilePath": {
-                    "default": "${workspaceFolder}/.vscode/tags",
-                    "description": "Fully qualified path to tag file (exuberant ctag file), used to provide workspace symbols.",
-                    "scope": "resource",
-                    "type": "string"
                 }
             },
             "title": "Python",
@@ -1826,18 +1769,6 @@
                     "group": "Python",
                     "when": "editorFocus && editorLangId == python"
                 },
-                {
-                    "command": "python.refactorExtractMethod",
-                    "group": "Refactor",
-                    "title": "Refactor: Extract Method",
-                    "when": "editorHasSelection && editorLangId == python && !notebookEditorFocused"
-                },
-                {
-                    "command": "python.refactorExtractVariable",
-                    "group": "Refactor",
-                    "title": "Refactor: Extract Variable",
-                    "when": "editorHasSelection && editorLangId == python && !notebookEditorFocused"
-                },
                 {
                     "command": "python.sortImports",
                     "group": "Refactor",

package.nls.de.json

@@ -2,11 +2,8 @@
     "python.command.python.sortImports.title": "Sortieren der Importe",
     "python.command.python.startREPL.title": "Starten des REPL",
     "python.command.python.createTerminal.title": "Terminal erstellen",
-    "python.command.python.buildWorkspaceSymbols.title": "Arbeitsplatz-Symbole erstellen",
     "python.command.python.execInTerminal.title": "Python-Datei im Terminal ausführen",
     "python.command.python.setInterpreter.title": "Interpreter auswählen",
-    "python.command.python.refactorExtractVariable.title": "Variable extrahieren",
-    "python.command.python.refactorExtractMethod.title": "Methode extrahieren",
     "python.command.python.execSelectionInTerminal.title": "Selektion/Reihe in Python-Terminal ausführen",
     "python.command.python.execSelectionInDjangoShell.title": "Selektion/Reihe in Django-Shell ausführen",
     "python.command.python.goToPythonObject.title": "Gehe zu Python-Objekt",