Skip to content

Commit 8b7850a

Browse files
debontekimadeline
andauthored
Apply suggestions from code review
Co-authored-by: Kim-Adeline Miguel <[email protected]>
1 parent 752622d commit 8b7850a

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

src/client/languageServer/watcher.ts

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -187,12 +187,10 @@ export class LanguageServerWatcher
187187
}
188188

189189
public async restartLanguageServers(): Promise<void> {
190-
const workspacesUris = this.workspaceService.workspaceFolders?.map((workspace) => workspace.uri) ?? [];
191-
192-
workspacesUris.forEach(async (resource) => {
193-
const lsResource = this.getWorkspaceUri(resource);
190+
this.workspaceLanguageServers.forEach(async (_, resourceString) => {
191+
const resource = Uri.parse(resourceString);
194192
this.stopLanguageServer(resource);
195-
await this.startLanguageServer(this.languageServerType, lsResource);
193+
await this.startLanguageServer(this.languageServerType, resource);
196194
});
197195
}
198196

src/client/telemetry/index.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1412,6 +1412,9 @@ export interface IEventNamePropertyMapping {
14121412
/**
14131413
* Telemetry event sent when the installed versions of Python, Jupyter, and Pylance are all capable
14141414
* of supporting the LSP notebooks experiment. This does not indicate that the experiment is enabled.
1415+
*/
1416+
/* __GDPR__
1417+
"python_experiments_lsp_notebooks" : { "owner": "luabud" }
14151418
*/
14161419
[EventName.PYTHON_EXPERIMENTS_LSP_NOTEBOOKS]: unknown;
14171420
/**

0 commit comments

Comments
 (0)