Skip to content

Commit 80ef35f

Browse files
author
Kartik Raj
authored
Log as error in case we're unable to detect the active terminal shell type (#20545)
1 parent 34414c8 commit 80ef35f

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/client/common/terminal/shellDetector.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
'use strict';
55

66
import { inject, injectable, multiInject } from 'inversify';
7-
import { Terminal } from 'vscode';
8-
import { traceVerbose } from '../../logging';
7+
import { Terminal, env } from 'vscode';
8+
import { traceError, traceVerbose } from '../../logging';
99
import { sendTelemetryEvent } from '../../telemetry';
1010
import { EventName } from '../../telemetry/constants';
1111
import '../extensions';
@@ -70,6 +70,7 @@ export class ShellDetector {
7070

7171
// If we could not identify the shell, use the defaults.
7272
if (shell === undefined || shell === TerminalShellType.other) {
73+
traceError('Unable to identify shell', env.shell, ' for OS ', this.platform.osType);
7374
traceVerbose('Using default OS shell');
7475
shell = defaultOSShells[this.platform.osType];
7576
}

0 commit comments

Comments
 (0)