Skip to content

re-select "set as workspace env" does nothing #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
eleanorjboyd opened this issue Dec 3, 2024 · 2 comments · Fixed by #441
Closed

re-select "set as workspace env" does nothing #58

eleanorjboyd opened this issue Dec 3, 2024 · 2 comments · Fixed by #441
Assignees
@karthiknadig @Copilot
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority verification-needed Verification of issue is requested
Milestone
May 2025

Comments

@eleanorjboyd
Copy link
Member

Testing #24503

  1. select venv as the workspace venv already
  2. click "set as workspace env"
  3. 🐛 nothing seems to happen because I am selecting the environment that was already selected
    ideas:
  • grey out that option
  • show notif that it was already selected

Image
@karthiknadig karthiknadig transferred this issue from microsoft/vscode-python Dec 4, 2024
@karthiknadig
Copy link
Member

@cwebster-99 @luabud I need some input here. The issue here is that we want to show the ✔️ to select for multi-project scenarios. Suppose you have two environments, and two projects, and each one is selected for each project. Then the ✔️ is necessary as you might want to select the same environment for both projects. E.g, env1 -> project1, env2-> project2, user might want to select env1 -> project1, project2. By removing ✔️it makes it harder to select it.

But I also see the confusion that people can have with clicking the ✔️ on the selected environment.

@cwebster-99
Copy link
Member

Discussed offline and decided to surface a notification communicating that the environment has already been selected in the following scenario

  • User has one folder/project open
  • User tries to select the same environment that is already selected

@karthiknadig karthiknadig added this to the January 2025 milestone Dec 16, 2024
@karthiknadig karthiknadig added the bug Issue identified by VS Code Team member as probable bug label Dec 16, 2024
@karthiknadig karthiknadig removed this from the January 2025 milestone Jan 27, 2025
@cwebster-99 cwebster-99 added the important Issue identified as high-priority label Mar 26, 2025
@Copilot Copilot AI mentioned this issue May 21, 2025
Merged
eleanorjboyd added a commit that referenced this issue May 22, 2025
@Copilot @eleanorjboyd
Add notification when re-selecting the same workspace environment (#441)
522ffac 
fixes #58

## Problem

When a user selects "Set As Workspace Environment" for an environment
that's already selected as the workspace environment, there's no
feedback provided to the user. This can be confusing, as it appears that
nothing happens when clicking the button.

## Solution

This PR adds feedback to users when they attempt to select an
environment that's already set as the workspace environment:

1. When a user has one folder/project open and tries to set the same
environment that's already selected
2. The user will now see an information message: "This environment is
already selected for the workspace." but its more verbose

Fixes #58 and refined by @eleanorjboyd

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: eleanorjboyd <[email protected]>
@eleanorjboyd eleanorjboyd added the verification-needed Verification of issue is requested label May 30, 2025
@eleanorjboyd eleanorjboyd added this to the May 2025 milestone May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karthiknadig karthiknadig

Copilot code review Copilot

Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority verification-needed Verification of issue is requested
Projects
None yet
Milestone
May 2025
3 participants
@karthiknadig @eleanorjboyd @cwebster-99