Skip to content

Update Translations #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 25, 2023
Merged

Update Translations #7

merged 3 commits into from
May 25, 2023

Conversation

paulacamargo25
Copy link
Contributor

@paulacamargo25 paulacamargo25 commented May 25, 2023

Following https://github.com/microsoft/vscode-engineering/wiki/Extensions-Localization

This onboards vscode-debugpy to the new localization API which enables localization for the web.

Closed: #8

@paulacamargo25 paulacamargo25 self-assigned this May 25, 2023
@paulacamargo25 paulacamargo25 enabled auto-merge May 25, 2023 15:38
Copy link
Contributor

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you clarify what this is supposed to address? Maybe link an issue in the PR

@paulacamargo25 paulacamargo25 requested a review from karrtikr May 25, 2023 16:13
Copy link
Contributor

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good idea to create an issue as well (assigned to current milestone) so the fixes we make can be verified next week. Other than that looks good.

@paulacamargo25 paulacamargo25 merged commit 3392278 into main May 25, 2023
@paulacamargo25 paulacamargo25 deleted the Update-translations branch May 25, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update localization
2 participants