Skip to content

Initial pass removing old linting documentation #6193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 15, 2023
Merged

Conversation

karthiknadig
Copy link
Member

@karthiknadig karthiknadig commented Mar 31, 2023

This is linting documentation for linting using the new extensions. The old page that this is replacing is still valid, but we are deprecating it starting milestone of June 2023.

@gregvanl What do you recommend, do we create a different page for this or replace the existing one with this? The old settings will be valid till we remove it from the extension which is planned for last quarter of this year.

@karthiknadig karthiknadig self-assigned this Mar 31, 2023
Co-authored-by: Courtney Webster <[email protected]>
@karthiknadig karthiknadig marked this pull request as ready for review June 9, 2023 19:44
@gregvanl
Copy link

gregvanl commented Jun 9, 2023

@karthiknadig For the question about a new topic or just update the existing, I would say update the existing topic with the currently available and recommended settings.
If there are soon-to-be-deprecated settings in the extension, you don't need to document them and users can still find them and their descriptions in the Settings editor and JSON IntelliSense

luabud
luabud previously approved these changes Jun 14, 2023
Copy link
Member

@luabud luabud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thank you so much for working on this 😊

@gregvanl
Copy link

@karthiknadig @luabud I did a quick edit/formatting pass and commit so the PR will need another approval before it can be merged. Looks good!

Copy link
Member

@cwebster-99 cwebster-99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants