Skip to content
This repository was archived by the owner on Nov 30, 2023. It is now read-only.

Add Devcontainer for Vue.js #395

Merged
merged 6 commits into from
Jul 9, 2020
Merged

Add Devcontainer for Vue.js #395

merged 6 commits into from
Jul 9, 2020

Conversation

AarynSmith
Copy link
Contributor

@AarynSmith AarynSmith commented Jul 6, 2020

This adds a config for Vue.js using a node image.

@Chuxel I debated running the same image from the others and rolling in node, but not sure thats any more efficent, or do you think I should copy the javascript-node-14 config and add in the Vue install?

@Chuxel
Copy link
Member

Chuxel commented Jul 6, 2020

Or you can just reference mcr.microsoft.com/vscode/devcontainers/javascript-node:14. In many ways that would probably be better since the rest of the Node related definitions are Debian based instead of Alpine (and not all extensions will work in an Alpine image due to native dependencies). Is there a specific reason to use the Alpine image?

@AarynSmith
Copy link
Contributor Author

AarynSmith commented Jul 7, 2020

Looks like the javascript-node:14 image works fine. I was trying to minimize sizes and stick to the Alpine image, but if it will mean better compatibility, I have no problem switching to the Debian based. This should make it compatible with Codespaces as well correct?

@AarynSmith AarynSmith marked this pull request as ready for review July 7, 2020 23:49
@Chuxel Chuxel self-requested a review July 9, 2020 13:42
Copy link
Member

@Chuxel Chuxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing I just noticed is that this is missing a .npmignore file. That's used to exclude folders/files when it is added to a project through VS Code.

e.g.

README.md
test-project
definition-manifest.json
.vscode
.npmignore

@AarynSmith
Copy link
Contributor Author

One thing I just noticed is that this is missing a .npmignore file. That's used to exclude folders/files when it is added to a project through VS Code.

e.g.

README.md
test-project
definition-manifest.json
.vscode
.npmignore

Added.

@Chuxel
Copy link
Member

Chuxel commented Jul 9, 2020

LGTM! Thanks!

@Chuxel Chuxel merged commit 73f7701 into microsoft:master Jul 9, 2020
@AarynSmith
Copy link
Contributor Author

Awesome thanks!

@AarynSmith AarynSmith deleted the vue-container branch July 10, 2020 01:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants