Skip to content

Commit d03af2d

Browse files
authored
Fix SIG-?? matching the filter regex. (#13493)
1 parent a204903 commit d03af2d

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

Extension/src/LanguageServer/extension.ts

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1210,7 +1210,9 @@ async function handleCrashFileRead(crashDirectory: string, crashFile: string, cr
12101210
signalType = lines[crashStackStartLine] + "\n";
12111211
} else {
12121212
// The signal type may fail to be written.
1213-
signalType = "SIG-??\n"; // Intentionally different from SIG-? from cpptools.
1213+
// Intentionally different from SIGUNKNOWN from cpptools,
1214+
// and not SIG-? to avoid matching the regex in containsFilteredTelemetryData.
1215+
signalType = "SIGMISSING\n";
12141216
}
12151217
data = telemetryHeader + signalType;
12161218
let crashCallStack: string = "";
@@ -1329,11 +1331,6 @@ async function handleCrashFileRead(crashDirectory: string, crashFile: string, cr
13291331

13301332
data += crashCallStack;
13311333

1332-
// TODO: Remove this in 1.25.1 after it's confirmed that it's not happening.
1333-
if (containsFilteredTelemetryData(data)) {
1334-
data = "unexpected call stack\n";
1335-
}
1336-
13371334
logCppCrashTelemetry(data, addressData, crashLog);
13381335

13391336
await util.deleteFile(path.resolve(crashDirectory, crashFile)).catch(logAndReturn.undefined);

0 commit comments

Comments
 (0)