Remove ScriptTarget from source affecting options #1205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakebailey
commented
Jun 16, 2025
jakebailey
commented
Jun 16, 2025
| @@ -231,7 +229,7 @@ func defaultScanner() Scanner { | |||
| // Using a function rather than a global is intentional; this function is | |||
| // inlined as pure code (zeroing + moves), whereas a global requires write | |||
| // barriers since the memory is mutable. | |||
| return Scanner{languageVersion: core.ScriptTargetLatest, skipTrivia: true} | |||
| return Scanner{skipTrivia: true} | |||
There was a problem hiding this comment.
If I make skipTrivia a method, then flip the default, then we can also reset scanners with zeroing, which would be amazing.
sheetalkamat
approved these changes
Jun 17, 2025
|
The verdict was "do this, and keep removing options" plus "reintroduce regexp checking as grammar checks". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This warrants some discussion, but after #1203, the language version is actually no longer needed at all for parsing, and can be dropped from binding if we assume no ES5 support. This means we could share ASTs no matter which language version they're used with, which is pretty neat.
The only gotcha is that the scanner is still missing the regex parse error code, and the language version is needed there to give correct errors.
Honestly, I think we should do this PR to get even more AST reuse, and then go put the regex checking code elsewhere, like in the checker itself or something.