Skip to content

Commit 8da7fc7

Browse files
authored
Sort failingTests and manualTests in en-US (#2113)
1 parent c846370 commit 8da7fc7

File tree

3 files changed

+63
-63
lines changed

3 files changed

+63
-63
lines changed

internal/fourslash/_scripts/failingTests.txt

Lines changed: 61 additions & 61 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ TestAutoImportModuleNone1
1717
TestAutoImportNodeNextJSRequire
1818
TestAutoImportPathsAliasesAndBarrels
1919
TestAutoImportPnpm
20-
TestAutoImportProvider4
2120
TestAutoImportProvider_exportMap1
2221
TestAutoImportProvider_exportMap2
2322
TestAutoImportProvider_exportMap3
@@ -33,6 +32,7 @@ TestAutoImportProvider_pnpm
3332
TestAutoImportProvider_wildcardExports1
3433
TestAutoImportProvider_wildcardExports2
3534
TestAutoImportProvider_wildcardExports3
35+
TestAutoImportProvider4
3636
TestAutoImportSortCaseSensitivity1
3737
TestAutoImportSymlinkCaseSensitive
3838
TestAutoImportTypeImport1
@@ -60,6 +60,16 @@ TestCompletionForComputedStringProperties
6060
TestCompletionForMetaProperty
6161
TestCompletionForObjectProperty
6262
TestCompletionForStringLiteral
63+
TestCompletionForStringLiteral_details
64+
TestCompletionForStringLiteral_quotePreference
65+
TestCompletionForStringLiteral_quotePreference1
66+
TestCompletionForStringLiteral_quotePreference2
67+
TestCompletionForStringLiteral_quotePreference3
68+
TestCompletionForStringLiteral_quotePreference4
69+
TestCompletionForStringLiteral_quotePreference5
70+
TestCompletionForStringLiteral_quotePreference6
71+
TestCompletionForStringLiteral_quotePreference7
72+
TestCompletionForStringLiteral_quotePreference8
6373
TestCompletionForStringLiteral4
6474
TestCompletionForStringLiteralExport
6575
TestCompletionForStringLiteralImport1
@@ -81,16 +91,6 @@ TestCompletionForStringLiteralRelativeImport4
8191
TestCompletionForStringLiteralRelativeImport6
8292
TestCompletionForStringLiteralRelativeImportAllowJSTrue
8393
TestCompletionForStringLiteralWithDynamicImport
84-
TestCompletionForStringLiteral_details
85-
TestCompletionForStringLiteral_quotePreference
86-
TestCompletionForStringLiteral_quotePreference1
87-
TestCompletionForStringLiteral_quotePreference2
88-
TestCompletionForStringLiteral_quotePreference3
89-
TestCompletionForStringLiteral_quotePreference4
90-
TestCompletionForStringLiteral_quotePreference5
91-
TestCompletionForStringLiteral_quotePreference6
92-
TestCompletionForStringLiteral_quotePreference7
93-
TestCompletionForStringLiteral_quotePreference8
9494
TestCompletionImportMeta
9595
TestCompletionImportMetaWithGlobalDeclaration
9696
TestCompletionImportModuleSpecifierEndingDts
@@ -128,16 +128,16 @@ TestCompletionListInUnclosedTaggedTemplate02
128128
TestCompletionListInUnclosedTemplate01
129129
TestCompletionListInUnclosedTemplate02
130130
TestCompletionListInvalidMemberNames
131-
TestCompletionListInvalidMemberNames2
132131
TestCompletionListInvalidMemberNames_escapeQuote
133132
TestCompletionListInvalidMemberNames_startWithSpace
134133
TestCompletionListInvalidMemberNames_withExistingIdentifier
134+
TestCompletionListInvalidMemberNames2
135135
TestCompletionListOfGenericSymbol
136136
TestCompletionListOnAliases
137+
TestCompletionListsStringLiteralTypeAsIndexedAccessTypeObject
137138
TestCompletionListStringParenthesizedExpression
138139
TestCompletionListStringParenthesizedType
139140
TestCompletionListWithoutVariableinitializer
140-
TestCompletionListsStringLiteralTypeAsIndexedAccessTypeObject
141141
TestCompletionNoAutoInsertQuestionDotForThis
142142
TestCompletionNoAutoInsertQuestionDotForTypeParameter
143143
TestCompletionNoAutoInsertQuestionDotWithUserPreferencesOff
@@ -149,7 +149,6 @@ TestCompletionOfAwaitPromise6
149149
TestCompletionOfAwaitPromise7
150150
TestCompletionOfInterfaceAndVar
151151
TestCompletionPreferredSuggestions1
152-
TestCompletionWithConditionalOperatorMissingColon
153152
TestCompletionsAfterJSDoc
154153
TestCompletionsBeforeRestArg1
155154
TestCompletionsClassMemberImportTypeNodeParameter1
@@ -159,7 +158,6 @@ TestCompletionsClassMemberImportTypeNodeParameter4
159158
TestCompletionsElementAccessNumeric
160159
TestCompletionsExportImport
161160
TestCompletionsGenericTypeWithMultipleBases1
162-
TestCompletionsImportOrExportSpecifier
163161
TestCompletionsImport_default_alreadyExistedWithRename
164162
TestCompletionsImport_default_anonymous
165163
TestCompletionsImport_details_withMisspelledName
@@ -176,13 +174,14 @@ TestCompletionsImport_named_didNotExistBefore
176174
TestCompletionsImport_noSemicolons
177175
TestCompletionsImport_packageJsonImportsPreference
178176
TestCompletionsImport_quoteStyle
179-
TestCompletionsImport_reExportDefault2
180177
TestCompletionsImport_reExport_wrongName
178+
TestCompletionsImport_reExportDefault2
181179
TestCompletionsImport_require_addToExisting
182180
TestCompletionsImport_typeOnly
183181
TestCompletionsImport_umdDefaultNoCrash1
184182
TestCompletionsImport_uriStyleNodeCoreModules2
185183
TestCompletionsImport_windowsPathsProjectRelative
184+
TestCompletionsImportOrExportSpecifier
186185
TestCompletionsInExport
187186
TestCompletionsInExport_moduleBlock
188187
TestCompletionsInRequire
@@ -207,23 +206,24 @@ TestCompletionsOverridingMethod4
207206
TestCompletionsOverridingMethod9
208207
TestCompletionsOverridingMethodCrash1
209208
TestCompletionsOverridingProperties1
210-
TestCompletionsPathsJsonModule
211-
TestCompletionsPathsRelativeJsonModule
212209
TestCompletionsPaths_importType
213210
TestCompletionsPaths_kinds
214211
TestCompletionsPaths_pathMapping
215212
TestCompletionsPaths_pathMapping_nonTrailingWildcard1
216213
TestCompletionsPaths_pathMapping_parentDirectory
214+
TestCompletionsPathsJsonModule
215+
TestCompletionsPathsRelativeJsonModule
217216
TestCompletionsRecommended_namespace
218217
TestCompletionsRecommended_union
219218
TestCompletionsRedeclareModuleAsGlobal
220219
TestCompletionsStringsWithTriggerCharacter
221220
TestCompletionsSymbolMembers
222221
TestCompletionsTriggerCharacter
223222
TestCompletionsTuple
224-
TestCompletionsUniqueSymbol1
225223
TestCompletionsUniqueSymbol_import
224+
TestCompletionsUniqueSymbol1
226225
TestCompletionsWithDeprecatedTag10
226+
TestCompletionWithConditionalOperatorMissingColon
227227
TestConstEnumQuickInfoAndCompletionList
228228
TestConstQuickInfoAndCompletionList
229229
TestContextuallyTypedFunctionExpressionGeneric1
@@ -233,8 +233,8 @@ TestExportDefaultClass
233233
TestExportDefaultFunction
234234
TestFindReferencesBindingPatternInJsdocNoCrash1
235235
TestFindReferencesBindingPatternInJsdocNoCrash2
236-
TestGenericCombinatorWithConstraints1
237236
TestGenericCombinators3
237+
TestGenericCombinatorWithConstraints1
238238
TestGenericFunctionWithGenericParams1
239239
TestGenericInterfacesWithConstraints1
240240
TestGenericTypeWithMultipleBases1MultiFile
@@ -258,25 +258,43 @@ TestGetJavaScriptQuickInfo8
258258
TestGetJavaScriptSyntacticDiagnostics24
259259
TestGetOccurrencesIfElseBroken
260260
TestHoverOverComment
261+
TestImportCompletions_importsMap1
262+
TestImportCompletions_importsMap2
263+
TestImportCompletions_importsMap3
264+
TestImportCompletions_importsMap4
265+
TestImportCompletions_importsMap5
261266
TestImportCompletionsPackageJsonExportsSpecifierEndsInTs
262267
TestImportCompletionsPackageJsonExportsTrailingSlash1
268+
TestImportCompletionsPackageJsonImports_ts
263269
TestImportCompletionsPackageJsonImportsConditions1
264270
TestImportCompletionsPackageJsonImportsLength1
265271
TestImportCompletionsPackageJsonImportsLength2
266272
TestImportCompletionsPackageJsonImportsPattern
267-
TestImportCompletionsPackageJsonImportsPattern2
268273
TestImportCompletionsPackageJsonImportsPattern_capsInPath1
269274
TestImportCompletionsPackageJsonImportsPattern_capsInPath2
270275
TestImportCompletionsPackageJsonImportsPattern_js_ts
271276
TestImportCompletionsPackageJsonImportsPattern_ts
272277
TestImportCompletionsPackageJsonImportsPattern_ts_ts
273-
TestImportCompletionsPackageJsonImports_ts
274-
TestImportCompletions_importsMap1
275-
TestImportCompletions_importsMap2
276-
TestImportCompletions_importsMap3
277-
TestImportCompletions_importsMap4
278-
TestImportCompletions_importsMap5
278+
TestImportCompletionsPackageJsonImportsPattern2
279279
TestImportFixesGlobalTypingsCache
280+
TestImportNameCodeFix_avoidRelativeNodeModules
281+
TestImportNameCodeFix_fileWithNoTrailingNewline
282+
TestImportNameCodeFix_HeaderComment1
283+
TestImportNameCodeFix_HeaderComment2
284+
TestImportNameCodeFix_importType1
285+
TestImportNameCodeFix_importType2
286+
TestImportNameCodeFix_importType4
287+
TestImportNameCodeFix_importType7
288+
TestImportNameCodeFix_importType8
289+
TestImportNameCodeFix_jsx1
290+
TestImportNameCodeFix_order
291+
TestImportNameCodeFix_order2
292+
TestImportNameCodeFix_pnpm1
293+
TestImportNameCodeFix_preferBaseUrl
294+
TestImportNameCodeFix_reExportDefault
295+
TestImportNameCodeFix_symlink
296+
TestImportNameCodeFix_trailingComma
297+
TestImportNameCodeFix_withJson
280298
TestImportNameCodeFixConvertTypeOnly1
281299
TestImportNameCodeFixExistingImport10
282300
TestImportNameCodeFixExistingImport11
@@ -297,24 +315,6 @@ TestImportNameCodeFixNewImportFileQuoteStyleMixed0
297315
TestImportNameCodeFixNewImportFileQuoteStyleMixed1
298316
TestImportNameCodeFixNewImportRootDirs0
299317
TestImportNameCodeFixNewImportTypeRoots1
300-
TestImportNameCodeFix_HeaderComment1
301-
TestImportNameCodeFix_HeaderComment2
302-
TestImportNameCodeFix_avoidRelativeNodeModules
303-
TestImportNameCodeFix_fileWithNoTrailingNewline
304-
TestImportNameCodeFix_importType1
305-
TestImportNameCodeFix_importType2
306-
TestImportNameCodeFix_importType4
307-
TestImportNameCodeFix_importType7
308-
TestImportNameCodeFix_importType8
309-
TestImportNameCodeFix_jsx1
310-
TestImportNameCodeFix_order
311-
TestImportNameCodeFix_order2
312-
TestImportNameCodeFix_pnpm1
313-
TestImportNameCodeFix_preferBaseUrl
314-
TestImportNameCodeFix_reExportDefault
315-
TestImportNameCodeFix_symlink
316-
TestImportNameCodeFix_trailingComma
317-
TestImportNameCodeFix_withJson
318318
TestImportTypeCompletions1
319319
TestImportTypeCompletions3
320320
TestImportTypeCompletions4
@@ -329,6 +329,7 @@ TestJavascriptModules20
329329
TestJavascriptModulesTypeImport
330330
TestJsDocAugments
331331
TestJsDocAugmentsAndExtends
332+
TestJsdocCallbackTag
332333
TestJsDocExtends
333334
TestJsDocFunctionSignatures10
334335
TestJsDocFunctionSignatures11
@@ -338,6 +339,9 @@ TestJsDocFunctionSignatures7
338339
TestJsDocFunctionSignatures8
339340
TestJsDocGenerics2
340341
TestJsDocInheritDoc
342+
TestJsdocLink2
343+
TestJsdocLink3
344+
TestJsdocLink6
341345
TestJsDocPropertyDescription1
342346
TestJsDocPropertyDescription10
343347
TestJsDocPropertyDescription11
@@ -352,19 +356,15 @@ TestJsDocPropertyDescription8
352356
TestJsDocPropertyDescription9
353357
TestJsDocServices
354358
TestJsDocTagsWithHyphen
355-
TestJsFileImportNoTypes2
356-
TestJsQuickInfoGenerallyAcceptableSize
357-
TestJsRequireQuickInfo
358-
TestJsdocCallbackTag
359-
TestJsdocLink2
360-
TestJsdocLink3
361-
TestJsdocLink6
362359
TestJsdocTemplatePrototypeCompletions
363360
TestJsdocThrowsTagCompletion
364361
TestJsdocTypedefTag
365362
TestJsdocTypedefTag2
366363
TestJsdocTypedefTagNamespace
367364
TestJsdocTypedefTagServices
365+
TestJsFileImportNoTypes2
366+
TestJsQuickInfoGenerallyAcceptableSize
367+
TestJsRequireQuickInfo
368368
TestLetQuickInfoAndCompletionList
369369
TestLocalFunction
370370
TestMemberListInReopenedEnum
@@ -374,9 +374,9 @@ TestMemberListOnContextualThis
374374
TestModuleNodeNextAutoImport2
375375
TestModuleNodeNextAutoImport3
376376
TestNgProxy1
377+
TestNodeModulesImportCompletions1
377378
TestNoQuickInfoForLabel
378379
TestNoQuickInfoInWhitespace
379-
TestNodeModulesImportCompletions1
380380
TestNumericPropertyNames
381381
TestOverloadQuickInfo
382382
TestParameterWithDestructuring
@@ -430,12 +430,14 @@ TestPathCompletionsTypesVersionsWildcard4
430430
TestPathCompletionsTypesVersionsWildcard5
431431
TestPathCompletionsTypesVersionsWildcard6
432432
TestProtoVarVisibleWithOuterScopeUnderscoreProto
433+
TestQuickInfo_notInsideComment
434+
TestQuickinfo01
433435
TestQuickInfoAlias
434436
TestQuickInfoAssertionNodeNotReusedWhenTypeNotEquivalent1
435437
TestQuickInfoBindingPatternInJsdocNoCrash1
436438
TestQuickInfoClassKeyword
437-
TestQuickInfoContextualTyping
438439
TestQuickInfoContextuallyTypedSignatureOptionalParameterFromIntersection1
440+
TestQuickInfoContextualTyping
439441
TestQuickInfoDisplayPartsIife
440442
TestQuickInfoElementAccessDeclaration
441443
TestQuickInfoForConstTypeReference
@@ -448,13 +450,15 @@ TestQuickInfoForGenericTaggedTemplateExpression
448450
TestQuickInfoForGetterAndSetter
449451
TestQuickInfoForIndexerResultWithConstraint
450452
TestQuickInfoForNamedTupleMember
453+
TestQuickinfoForNamespaceMergeWithClassConstrainedToSelf
451454
TestQuickInfoForObjectBindingElementPropertyName04
452455
TestQuickInfoForShorthandProperty
453456
TestQuickInfoForSyntaxErrorNoError
457+
TestQuickInfoForTypeofParameter
454458
TestQuickInfoForTypeParameterInTypeAlias1
455459
TestQuickInfoForTypeParameterInTypeAlias2
456-
TestQuickInfoForTypeofParameter
457460
TestQuickInfoForUMDModuleAlias
461+
TestQuickinfoForUnionProperty
458462
TestQuickInfoFunctionKeyword
459463
TestQuickInfoGenerics
460464
TestQuickInfoGetterSetter
@@ -465,10 +469,10 @@ TestQuickInfoInWithBlock
465469
TestQuickInfoJSDocBackticks
466470
TestQuickInfoJSDocFunctionNew
467471
TestQuickInfoJSDocFunctionThis
468-
TestQuickInfoJSExport
469472
TestQuickInfoJsDocGetterSetterNoCrash1
470473
TestQuickInfoJsDocNonDiscriminatedUnionSharedProp
471474
TestQuickInfoJsdocTypedefMissingType
475+
TestQuickInfoJSExport
472476
TestQuickInfoMappedSpreadTypes
473477
TestQuickInfoMappedType
474478
TestQuickInfoMappedTypeRecursiveInference
@@ -512,6 +516,7 @@ TestQuickInfoOnUndefined
512516
TestQuickInfoOnVarInArrowExpression
513517
TestQuickInfoPrivateIdentifierInTypeReferenceNoCrash1
514518
TestQuickInfoPropertyTag
519+
TestQuickInforForSucessiveInferencesIsNotAny
515520
TestQuickInfoSignatureOptionalParameterFromUnion1
516521
TestQuickInfoSignatureRestParameterFromUnion1
517522
TestQuickInfoSignatureRestParameterFromUnion2
@@ -526,11 +531,6 @@ TestQuickInfoTypeOfThisInStatics
526531
TestQuickInfoTypeOnlyNamespaceAndClass
527532
TestQuickInfoUnionOfNamespaces
528533
TestQuickInfoWidenedTypes
529-
TestQuickInfo_notInsideComment
530-
TestQuickInforForSucessiveInferencesIsNotAny
531-
TestQuickinfo01
532-
TestQuickinfoForNamespaceMergeWithClassConstrainedToSelf
533-
TestQuickinfoForUnionProperty
534534
TestQuickinfoWrongComment
535535
TestRecursiveInternalModuleImport
536536
TestReferencesInEmptyFile

internal/fourslash/_scripts/makeManual.mts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ function main() {
5656

5757
if (!manualTests.includes(testName)) {
5858
manualTests.push(testName);
59-
manualTests.sort();
59+
manualTests.sort((a, b) => a.localeCompare(b, "en-US"));
6060
fs.writeFileSync(manualTestsPath, [...manualTests, ""].join("\n"), "utf-8");
6161
}
6262
}

internal/fourslash/_scripts/updateFailing.mts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ function main() {
3131
failingTests.push(match[1]);
3232
}
3333

34-
fs.writeFileSync(failingTestsPath, failingTests.sort().join("\n") + "\n", "utf-8");
34+
fs.writeFileSync(failingTestsPath, failingTests.sort((a, b) => a.localeCompare(b, "en-US")).join("\n") + "\n", "utf-8");
3535
convertFourslash();
3636
}
3737

0 commit comments

Comments
 (0)