Skip to content

Fix filtering of TS5055 #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2022
Merged

Fix filtering of TS5055 #81

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,7 +444,9 @@ export async function getTscRepoResult(

// TS 5055 generally indicates that the project can't be built twice in a row without cleaning in between.
const newErrorList = newErrors.projectErrors.find(pe => pe.projectUrl == projectUrl)?.errors?.filter(e => e.code !== 5055) ?? [];
const oldErrorList = oldProjectErrors.errors;
// Obviously, 5055 doesn't indicate a problem with building twice if it occurs during the first build,
// but it's still not interesting to report that it went away (which we would, since we drop it from `newErrorList`).
const oldErrorList = oldProjectErrors.errors.filter(e => e.code !== 5055);

console.log(`Error counts for ${projectUrl}: new = ${newErrorList.length}, old = ${oldErrorList.length}`);

Expand Down