Merge pull request #3902 from iclanton/fix-create-scripts

[rush] Fix missing create-scripts.js file.

Author: iclanton

common/changes/@microsoft/rush/fix-create-scripts_2023-01-18-19-47.json

@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@microsoft/rush",
+      "comment": "Fix an issue where `create-scripts.js` does not exist during `rush deploy`.",
+      "type": "none"
+    }
+  ],
+  "packageName": "@microsoft/rush"
+}

libraries/rush-lib/src/logic/deploy/DeployManager.ts

@@ -31,7 +31,7 @@ import { RushConfigurationProject } from '../../api/RushConfigurationProject';
 import { DeployScenarioConfiguration, IDeployScenarioProjectJson } from './DeployScenarioConfiguration';
 import { PnpmfileConfiguration } from '../pnpm/PnpmfileConfiguration';
 import { matchesWithStar } from './Utils';
-import { scriptsFolderName } from '../../utilities/PathConstants';
+import { createLinksScriptFilename, scriptsFolderPath } from '../../utilities/PathConstants';
 
 // (@types/npm-packlist is missing this API)
 declare module 'npm-packlist' {
@@ -665,7 +665,7 @@ export class DeployManager {
     if (deployState.scenarioConfiguration.json.linkCreation === 'script') {
       console.log('Copying create-links.js');
       FileSystem.copyFile({
-        sourcePath: `${scriptsFolderName}/create-links.js`,
+        sourcePath: `${scriptsFolderPath}/${createLinksScriptFilename}`,
         destinationPath: path.join(deployState.targetRootFolder, 'create-links.js'),
         alreadyExistsBehavior: AlreadyExistsBehavior.Error
       });

libraries/rush-lib/src/utilities/PathConstants.ts

@@ -16,13 +16,14 @@ export const assetsFolderPath: string = `${rushLibFolderRootPath}/assets`;
 /**
  * The folder name ("scripts") where the scripts in rush-lib are built.
  */
-export const scriptsFolderName: string = 'scripts';
+const scriptsFolderName: string = 'scripts';
 
 export const pnpmfileShimFilename: string = 'PnpmfileShim.js';
 export const installRunScriptFilename: string = 'install-run.js';
 export const installRunRushScriptFilename: string = 'install-run-rush.js';
 export const installRunRushxScriptFilename: string = 'install-run-rushx.js';
 export const installRunRushPnpmScriptFilename: string = 'install-run-rush-pnpm.js';
+export const createLinksScriptFilename: string = 'create-links.js';
 
 /**
  * The path to the scripts folder in rush-lib/dist.

libraries/rush-lib/webpack.config.js

@@ -121,6 +121,10 @@ module.exports = () => {
       [PathConstants.installRunRushPnpmScriptFilename]: {
         import: `${__dirname}/lib-esnext/scripts/install-run-rush-pnpm.js`,
         ...SCRIPT_ENTRY_OPTIONS
+      },
+      [PathConstants.createLinksScriptFilename]: {
+        import: `${__dirname}/lib-esnext/scripts/create-links.js`,
+        ...SCRIPT_ENTRY_OPTIONS
       }
     })
   ];