Skip to content

Commit 3c32983

Browse files
gengjiawenfacebook-github-bot
authored andcommitted
enhance RNTester android config
Summary: * cliPath is not config right * root config can be better config instead of a relative path which can easily go wrong if location changed * DeveloperSupport should only be in debug mode. * make facebook/react-native#18732 change on local. * config signingConfig * execute `./gradlew :RNTester:android:app:assembleRelease`, and run app on device to check everything is fine. none [GENERAL][ENHANCEMENT][RNTester] Closes facebook/react-native#18746 Differential Revision: D7548846 Pulled By: hramos fbshipit-source-id: 8943f84a6c99456477dff2deeaacc96f093b2e09
1 parent 0461730 commit 3c32983

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

android/app/build.gradle

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,9 +58,10 @@ import com.android.build.OutputFile
5858
*/
5959

6060
project.ext.react = [
61+
cliPath: "$rootDir/local-cli/cli.js",
6162
bundleAssetName: "RNTesterApp.android.bundle",
6263
entryFile: file("../../js/RNTesterApp.android.js"),
63-
root: "../../../",
64+
root: "$rootDir",
6465
inputExcludes: ["android/**", "./**"]
6566
]
6667

android/app/src/main/java/com/facebook/react/uiapp/RNTesterApplication.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ public String getJSMainModuleName() {
3434

3535
@Override
3636
public boolean getUseDeveloperSupport() {
37-
return true;
37+
return BuildConfig.DEBUG;
3838
}
3939

4040
@Override

0 commit comments

Comments
 (0)