fix: enable sanitizers in Xcode build settings instead (#784)

tido64 · web-flow · commit 5b64b6715d22 · 2022-02-25T11:28:41.000+01:00
Enabling sanitizers in scheme causes issues on some setups when running
XCTests.
diff --git a/ios/ReactTestApp.xcodeproj/xcshareddata/xcschemes/ReactTestApp.xcscheme b/ios/ReactTestApp.xcodeproj/xcshareddata/xcschemes/ReactTestApp.xcscheme
@@ -54,8 +54,6 @@
       buildConfiguration = "Debug"
       selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
       selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
-      enableAddressSanitizer = "YES"
-      enableUBSanitizer = "YES"
       launchStyle = "0"
       useCustomWorkingDirectory = "NO"
       ignoresPersistentStateOnLaunch = "NO"
diff --git a/ios/ReactTestApp/ReactTestApp.debug.xcconfig b/ios/ReactTestApp/ReactTestApp.debug.xcconfig
@@ -1,5 +1,7 @@
 #include "ReactTestApp.common.xcconfig"
 
+CLANG_ADDRESS_SANITIZER = YES
+CLANG_UNDEFINED_BEHAVIOR_SANITIZER = YES
 DEBUG_INFORMATION_FORMAT = dwarf
 ENABLE_TESTABILITY = YES
 GCC_DYNAMIC_NO_PIC = NO
diff --git a/macos/ReactTestApp.xcodeproj/xcshareddata/xcschemes/ReactTestApp.xcscheme b/macos/ReactTestApp.xcodeproj/xcshareddata/xcschemes/ReactTestApp.xcscheme
@@ -54,8 +54,6 @@
       buildConfiguration = "Debug"
       selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
       selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
-      enableAddressSanitizer = "YES"
-      enableUBSanitizer = "YES"
       launchStyle = "0"
       useCustomWorkingDirectory = "NO"
       ignoresPersistentStateOnLaunch = "NO"
diff --git a/macos/ReactTestApp/ReactTestApp.debug.xcconfig b/macos/ReactTestApp/ReactTestApp.debug.xcconfig
@@ -1,5 +1,7 @@
 #include "ReactTestApp.common.xcconfig"
 
+CLANG_ADDRESS_SANITIZER = YES
+CLANG_UNDEFINED_BEHAVIOR_SANITIZER = YES
 DEBUG_INFORMATION_FORMAT = dwarf
 ENABLE_TESTABILITY = YES
 GCC_DYNAMIC_NO_PIC = NO
