Deprecate ShadowNode::ListOfShared and migrate to std::vector<std::shared_ptr<const ShadowNode>> (facebook#52402)

sammy-SC · facebook-github-bot · commit 1c51d6684b50 · 2025-07-07T06:15:29.000-07:00
Summary: Pull Request resolved: facebook#52402 changelog: [internal] Mark ShadowNode::ListOfShared as deprecated and replace most usages throughout the React Native renderer codebase with the explicit std::vector<std::shared_ptr<const ShadowNode>> type. This improves code clarity by making the container type explicit rather than relying on a type alias. Reviewed By: christophpurrer Differential Revision: D77651676 fbshipit-source-id: 8c4bd9b8cbbe467384b947ef9e7a4524f2053e36
diff --git a/packages/react-native/ReactCommon/react/nativemodule/dom/NativeDOM.cpp b/packages/react-native/ReactCommon/react/nativemodule/dom/NativeDOM.cpp
@@ -66,7 +66,7 @@ getPointerEventsProcessorFromRuntime(facebook::jsi::Runtime& runtime) {
 
 static std::vector<facebook::jsi::Value>
 getArrayOfInstanceHandlesFromShadowNodes(
-    const ShadowNode::ListOfShared& nodes,
+    const std::vector<std::shared_ptr<const ShadowNode>>& nodes,
     facebook::jsi::Runtime& runtime) {
   // JSI doesn't support adding elements to an array after creation,
   // so we need to accumulate the values in a vector and then create
diff --git a/packages/react-native/ReactCommon/react/nativemodule/fantomtestspecificmethods/internal/FantomForcedCloneCommitHook.cpp b/packages/react-native/ReactCommon/react/nativemodule/fantomtestspecificmethods/internal/FantomForcedCloneCommitHook.cpp
@@ -27,7 +27,8 @@ std::shared_ptr<const ShadowNode> findAndClone(
       children[i] = maybeClone;
       return node->clone(
           {ShadowNodeFragment::propsPlaceholder(),
-           std::make_shared<ShadowNode::ListOfShared>(children)});
+           std::make_shared<std::vector<std::shared_ptr<const ShadowNode>>>(
+               children)});
     }
   }
 
diff --git a/packages/react-native/ReactCommon/react/renderer/animations/tests/LayoutAnimationTest.cpp b/packages/react-native/ReactCommon/react/renderer/animations/tests/LayoutAnimationTest.cpp
@@ -117,8 +117,9 @@ static void testShadowNodeTreeLifeCycleLayoutAnimations(
     auto currentRootNode = std::static_pointer_cast<const RootShadowNode>(
         emptyRootNode->ShadowNode::clone(ShadowNodeFragment{
             ShadowNodeFragment::propsPlaceholder(),
-            std::make_shared<ShadowNode::ListOfShared>(
-                ShadowNode::ListOfShared{singleRootChildNode})}));
+            std::make_shared<std::vector<std::shared_ptr<const ShadowNode>>>(
+                std::vector<std::shared_ptr<const ShadowNode>>{
+                    singleRootChildNode})}));
 
     // Building an initial view hierarchy.
     auto viewTree = StubViewTree(ShadowView(*emptyRootNode));
diff --git a/packages/react-native/ReactCommon/react/renderer/components/view/tests/ViewTest.cpp b/packages/react-native/ReactCommon/react/renderer/components/view/tests/ViewTest.cpp
@@ -174,7 +174,9 @@ TEST_F(YogaDirtyFlagTest, removingLastChildMustDirtyYogaNode) {
 
         return oldShadowNode.clone(
             {ShadowNodeFragment::propsPlaceholder(),
-             std::make_shared<const ShadowNode::ListOfShared>(children)});
+             std::make_shared<
+                 const std::vector<std::shared_ptr<const ShadowNode>>>(
+                 children)});
       });
 
   EXPECT_TRUE(
@@ -193,7 +195,9 @@ TEST_F(YogaDirtyFlagTest, reversingListOfChildrenMustDirtyYogaNode) {
 
         return oldShadowNode.clone(
             {ShadowNodeFragment::propsPlaceholder(),
-             std::make_shared<const ShadowNode::ListOfShared>(children)});
+             std::make_shared<
+                 const std::vector<std::shared_ptr<const ShadowNode>>>(
+                 children)});
       });
 
   EXPECT_TRUE(
diff --git a/packages/react-native/ReactCommon/react/renderer/core/ShadowNode.cpp b/packages/react-native/ReactCommon/react/renderer/core/ShadowNode.cpp
@@ -35,7 +35,7 @@ thread_local bool useRuntimeShadowNodeReferenceUpdateOnThread{false}; // NOLINT
 
 ShadowNode::SharedListOfShared ShadowNode::emptySharedShadowNodeSharedList() {
   static const auto emptySharedShadowNodeSharedList =
-      std::make_shared<ShadowNode::ListOfShared>();
+      std::make_shared<std::vector<std::shared_ptr<const ShadowNode>>>();
   return emptySharedShadowNodeSharedList;
 }
 
@@ -177,7 +177,8 @@ ComponentHandle ShadowNode::getComponentHandle() const {
   return family_->getComponentHandle();
 }
 
-const ShadowNode::ListOfShared& ShadowNode::getChildren() const {
+const std::vector<std::shared_ptr<const ShadowNode>>& ShadowNode::getChildren()
+    const {
   return *children_;
 }
 
@@ -241,7 +242,8 @@ void ShadowNode::appendChild(const std::shared_ptr<const ShadowNode>& child) {
   ensureUnsealed();
 
   cloneChildrenIfShared();
-  auto& children = const_cast<ShadowNode::ListOfShared&>(*children_);
+  auto& children =
+      const_cast<std::vector<std::shared_ptr<const ShadowNode>>&>(*children_);
   children.push_back(child);
 
   child->family_->setParent(family_);
@@ -257,7 +259,8 @@ void ShadowNode::replaceChild(
   cloneChildrenIfShared();
   newChild->family_->setParent(family_);
 
-  auto& children = const_cast<ShadowNode::ListOfShared&>(*children_);
+  auto& children =
+      const_cast<std::vector<std::shared_ptr<const ShadowNode>>&>(*children_);
   auto size = children.size();
 
   if (suggestedIndex != std::numeric_limits<size_t>::max() &&
@@ -287,7 +290,8 @@ void ShadowNode::cloneChildrenIfShared() {
   }
 
   traits_.unset(ShadowNodeTraits::Trait::ChildrenAreShared);
-  children_ = std::make_shared<ShadowNode::ListOfShared>(*children_);
+  children_ = std::make_shared<std::vector<std::shared_ptr<const ShadowNode>>>(
+      *children_);
 }
 
 void ShadowNode::updateTraitsIfNeccessary() {
@@ -395,7 +399,9 @@ std::shared_ptr<ShadowNode> ShadowNode::cloneTree(
     children[childIndex] = childNode;
 
     childNode = parentNode.clone(
-        {.children = std::make_shared<ShadowNode::ListOfShared>(children)});
+        {.children =
+             std::make_shared<std::vector<std::shared_ptr<const ShadowNode>>>(
+                 children)});
   }
 
   return std::const_pointer_cast<ShadowNode>(childNode);
@@ -411,15 +417,17 @@ std::shared_ptr<ShadowNode> cloneMultipleRecursive(
         ShadowNode>(const ShadowNode&, const ShadowNodeFragment&)>& callback) {
   const auto* family = &shadowNode.getFamily();
   auto& children = shadowNode.getChildren();
-  std::shared_ptr<ShadowNode::ListOfShared> newChildren;
+  std::shared_ptr<std::vector<std::shared_ptr<const ShadowNode>>> newChildren;
   auto count = childrenCount.at(family);
 
   for (int i = 0; count > 0 && i < children.size(); i++) {
     const auto childFamily = &children[i]->getFamily();
     if (childrenCount.contains(childFamily)) {
       count--;
       if (!newChildren) {
-        newChildren = std::make_shared<ShadowNode::ListOfShared>(children);
+        newChildren =
+            std::make_shared<std::vector<std::shared_ptr<const ShadowNode>>>(
+                children);
       }
       (*newChildren)[i] = cloneMultipleRecursive(
           *children[i], familiesToUpdate, childrenCount, callback);
diff --git a/packages/react-native/ReactCommon/react/renderer/core/ShadowNode.h b/packages/react-native/ReactCommon/react/renderer/core/ShadowNode.h
@@ -41,10 +41,15 @@ class ShadowNode : public Sealable,
   // TODO(T223558094): delete this in the next version.
   using Unshared [[deprecated("Use std::shared_ptr<ShadowNode> instead")]] =
       std::shared_ptr<ShadowNode>;
-  using ListOfShared = std::vector<std::shared_ptr<const ShadowNode>>;
+  // TODO(T223558094): delete this in the next version.
+  using ListOfShared [[deprecated(
+      "Use std::vector<std::shared_ptr<const ShadowNode>> instead")]] =
+      std::vector<std::shared_ptr<const ShadowNode>>;
   using ListOfWeak = std::vector<std::weak_ptr<const ShadowNode>>;
-  using SharedListOfShared = std::shared_ptr<const ListOfShared>;
-  using UnsharedListOfShared = std::shared_ptr<ListOfShared>;
+  using SharedListOfShared =
+      std::shared_ptr<const std::vector<std::shared_ptr<const ShadowNode>>>;
+  using UnsharedListOfShared =
+      std::shared_ptr<std::vector<std::shared_ptr<const ShadowNode>>>;
   using UnsharedListOfWeak = std::shared_ptr<ListOfWeak>;
 
   using AncestorList = std::vector<std::pair<
@@ -145,7 +150,7 @@ class ShadowNode : public Sealable,
   ShadowNodeTraits getTraits() const;
 
   const Props::Shared& getProps() const;
-  const ListOfShared& getChildren() const;
+  const std::vector<std::shared_ptr<const ShadowNode>>& getChildren() const;
   const SharedEventEmitter& getEventEmitter() const;
   jsi::Value getInstanceHandle(jsi::Runtime& runtime) const;
   Tag getTag() const;
diff --git a/packages/react-native/ReactCommon/react/renderer/core/tests/ShadowNodeTest.cpp b/packages/react-native/ReactCommon/react/renderer/core/tests/ShadowNodeTest.cpp
@@ -78,8 +78,9 @@ class ShadowNodeTest : public testing::Test {
         familyABB,
         traits);
 
-    auto nodeABChildren = std::make_shared<ShadowNode::ListOfShared>(
-        ShadowNode::ListOfShared{nodeABA_, nodeABB_});
+    auto nodeABChildren =
+        std::make_shared<std::vector<std::shared_ptr<const ShadowNode>>>(
+            std::vector<std::shared_ptr<const ShadowNode>>{nodeABA_, nodeABB_});
 
     auto familyAB = componentDescriptor_.createFamily(ShadowNodeFamilyFragment{
         /* .tag = */ 15,
@@ -107,8 +108,10 @@ class ShadowNodeTest : public testing::Test {
         familyAC,
         traits);
 
-    auto nodeAChildren = std::make_shared<ShadowNode::ListOfShared>(
-        ShadowNode::ListOfShared{nodeAA_, nodeAB_, nodeAC_});
+    auto nodeAChildren =
+        std::make_shared<std::vector<std::shared_ptr<const ShadowNode>>>(
+            std::vector<std::shared_ptr<const ShadowNode>>{
+                nodeAA_, nodeAB_, nodeAC_});
 
     auto familyA = componentDescriptor_.createFamily(ShadowNodeFamilyFragment{
         /* .tag = */ 17,
diff --git a/packages/react-native/ReactCommon/react/renderer/element/ComponentBuilder.cpp b/packages/react-native/ReactCommon/react/renderer/element/ComponentBuilder.cpp
@@ -20,7 +20,7 @@ std::shared_ptr<ShadowNode> ComponentBuilder::build(
   auto& componentDescriptor =
       componentDescriptorRegistry_->at(elementFragment.componentHandle);
 
-  auto children = ShadowNode::ListOfShared{};
+  auto children = std::vector<std::shared_ptr<const ShadowNode>>{};
   children.reserve(elementFragment.children.size());
   for (const auto& childFragment : elementFragment.children) {
     children.push_back(build(childFragment));
@@ -35,7 +35,8 @@ std::shared_ptr<ShadowNode> ComponentBuilder::build(
   auto constShadowNode = componentDescriptor.createShadowNode(
       ShadowNodeFragment{
           elementFragment.props,
-          std::make_shared<const ShadowNode::ListOfShared>(children),
+          std::make_shared<
+              const std::vector<std::shared_ptr<const ShadowNode>>>(children),
           initialState},
       family);
 
diff --git a/packages/react-native/ReactCommon/react/renderer/element/tests/ElementTest.cpp b/packages/react-native/ReactCommon/react/renderer/element/tests/ElementTest.cpp
@@ -85,9 +85,11 @@ TEST(ElementTest, testNormalCases) {
   EXPECT_EQ(shadowNodeABA->getChildren().size(), 0);
   EXPECT_EQ(
       shadowNodeA->getChildren(),
-      (ShadowNode::ListOfShared{shadowNodeAA, shadowNodeAB}));
+      (std::vector<std::shared_ptr<const ShadowNode>>{
+          shadowNodeAA, shadowNodeAB}));
   EXPECT_EQ(
-      shadowNodeAB->getChildren(), (ShadowNode::ListOfShared{shadowNodeABA}));
+      shadowNodeAB->getChildren(),
+      (std::vector<std::shared_ptr<const ShadowNode>>{shadowNodeABA}));
 
   // Props
   EXPECT_EQ(shadowNodeA->getProps()->nativeId, "node A");
diff --git a/packages/react-native/ReactCommon/react/renderer/mounting/ShadowTree.cpp b/packages/react-native/ReactCommon/react/renderer/mounting/ShadowTree.cpp
@@ -43,7 +43,7 @@ static std::shared_ptr<ShadowNode> progressState(const ShadowNode& shadowNode) {
     }
   }
 
-  auto newChildren = ShadowNode::ListOfShared{};
+  auto newChildren = std::vector<std::shared_ptr<const ShadowNode>>{};
   if (!shadowNode.getChildren().empty()) {
     auto index = size_t{0};
     for (const auto& childNode : shadowNode.getChildren()) {
@@ -66,9 +66,11 @@ static std::shared_ptr<ShadowNode> progressState(const ShadowNode& shadowNode) {
 
   return shadowNode.clone({
       ShadowNodeFragment::propsPlaceholder(),
-      areChildrenChanged ? std::make_shared<const ShadowNode::ListOfShared>(
-                               std::move(newChildren))
-                         : ShadowNodeFragment::childrenPlaceholder(),
+      areChildrenChanged
+          ? std::make_shared<
+                const std::vector<std::shared_ptr<const ShadowNode>>>(
+                std::move(newChildren))
+          : ShadowNodeFragment::childrenPlaceholder(),
       isStateChanged ? newState : ShadowNodeFragment::statePlaceholder(),
   });
 }
@@ -102,7 +104,7 @@ static std::shared_ptr<ShadowNode> progressState(
 
   auto& children = shadowNode.getChildren();
   auto& baseChildren = baseShadowNode.getChildren();
-  auto newChildren = ShadowNode::ListOfShared{};
+  auto newChildren = std::vector<std::shared_ptr<const ShadowNode>>{};
 
   auto childrenSize = children.size();
   auto baseChildrenSize = baseChildren.size();
@@ -153,9 +155,11 @@ static std::shared_ptr<ShadowNode> progressState(
 
   return shadowNode.clone({
       ShadowNodeFragment::propsPlaceholder(),
-      areChildrenChanged ? std::make_shared<const ShadowNode::ListOfShared>(
-                               std::move(newChildren))
-                         : ShadowNodeFragment::childrenPlaceholder(),
+      areChildrenChanged
+          ? std::make_shared<
+                const std::vector<std::shared_ptr<const ShadowNode>>>(
+                std::move(newChildren))
+          : ShadowNodeFragment::childrenPlaceholder(),
       isStateChanged ? newState : ShadowNodeFragment::statePlaceholder(),
   });
 }
diff --git a/packages/react-native/ReactCommon/react/renderer/mounting/tests/ShadowTreeLifeCycleTest.cpp b/packages/react-native/ReactCommon/react/renderer/mounting/tests/ShadowTreeLifeCycleTest.cpp
@@ -76,8 +76,9 @@ static void testShadowNodeTreeLifeCycle(
     auto currentRootNode = std::static_pointer_cast<const RootShadowNode>(
         emptyRootNode->ShadowNode::clone(ShadowNodeFragment{
             ShadowNodeFragment::propsPlaceholder(),
-            std::make_shared<ShadowNode::ListOfShared>(
-                ShadowNode::ListOfShared{singleRootChildNode})}));
+            std::make_shared<std::vector<std::shared_ptr<const ShadowNode>>>(
+                std::vector<std::shared_ptr<const ShadowNode>>{
+                    singleRootChildNode})}));
 
     // Building an initial view hierarchy.
     auto viewTree = StubViewTree(ShadowView(*emptyRootNode));
@@ -224,8 +225,9 @@ static void testShadowNodeTreeLifeCycleExtensiveFlatteningUnflattening(
     auto currentRootNode = std::static_pointer_cast<const RootShadowNode>(
         emptyRootNode->ShadowNode::clone(ShadowNodeFragment{
             ShadowNodeFragment::propsPlaceholder(),
-            std::make_shared<ShadowNode::ListOfShared>(
-                ShadowNode::ListOfShared{singleRootChildNode})}));
+            std::make_shared<std::vector<std::shared_ptr<const ShadowNode>>>(
+                std::vector<std::shared_ptr<const ShadowNode>>{
+                    singleRootChildNode})}));
 
     // Building an initial view hierarchy.
     auto viewTree = buildStubViewTreeWithoutUsingDifferentiator(*emptyRootNode);
diff --git a/packages/react-native/ReactCommon/react/renderer/mounting/updateMountedFlag.cpp b/packages/react-native/ReactCommon/react/renderer/mounting/updateMountedFlag.cpp
@@ -11,8 +11,8 @@
 
 namespace facebook::react {
 void updateMountedFlag(
-    const ShadowNode::ListOfShared& oldChildren,
-    const ShadowNode::ListOfShared& newChildren,
+    const std::vector<std::shared_ptr<const ShadowNode>>& oldChildren,
+    const std::vector<std::shared_ptr<const ShadowNode>>& newChildren,
     ShadowTreeCommitSource commitSource) {
   // This is a simplified version of Diffing algorithm that only updates
   // `mounted` flag on `ShadowNode`s. The algorithm sets "mounted" flag before
diff --git a/packages/react-native/ReactCommon/react/renderer/mounting/updateMountedFlag.h b/packages/react-native/ReactCommon/react/renderer/mounting/updateMountedFlag.h
@@ -15,7 +15,7 @@ namespace facebook::react {
  * Traverses the shadow tree and updates the `mounted` flag on all nodes.
  */
 void updateMountedFlag(
-    const ShadowNode::ListOfShared& oldChildren,
-    const ShadowNode::ListOfShared& newChildren,
+    const std::vector<std::shared_ptr<const ShadowNode>>& oldChildren,
+    const std::vector<std::shared_ptr<const ShadowNode>>& newChildren,
     ShadowTreeCommitSource commitSource);
 } // namespace facebook::react
diff --git a/packages/react-native/ReactCommon/react/renderer/observers/mutation/MutationObserver.cpp b/packages/react-native/ReactCommon/react/renderer/observers/mutation/MutationObserver.cpp
@@ -51,7 +51,7 @@ static std::shared_ptr<const ShadowNode> getShadowNodeInTree(
 }
 
 static std::shared_ptr<const ShadowNode> findNodeOfSameFamily(
-    const ShadowNode::ListOfShared& list,
+    const std::vector<std::shared_ptr<const ShadowNode>>& list,
     const ShadowNode& node) {
   for (auto& current : list) {
     if (ShadowNode::sameFamily(node, *current)) {
diff --git a/packages/react-native/ReactCommon/react/renderer/scheduler/SurfaceHandler.cpp b/packages/react-native/ReactCommon/react/renderer/scheduler/SurfaceHandler.cpp
@@ -248,7 +248,8 @@ std::shared_ptr<const ShadowNode> SurfaceHandler::dirtyMeasurableNodesRecursive(
       ShadowNodeFragment::childrenPlaceholder();
 
   if (nodeHasChildren) {
-    std::shared_ptr<ShadowNode::ListOfShared> newChildrenMutable = nullptr;
+    std::shared_ptr<std::vector<std::shared_ptr<const ShadowNode>>>
+        newChildrenMutable = nullptr;
     for (size_t i = 0; i < node->getChildren().size(); i++) {
       const auto& child = node->getChildren()[i];
 
@@ -259,8 +260,9 @@ std::shared_ptr<const ShadowNode> SurfaceHandler::dirtyMeasurableNodesRecursive(
 
         if (newChild != nullptr) {
           if (newChildrenMutable == nullptr) {
-            newChildrenMutable =
-                std::make_shared<ShadowNode::ListOfShared>(node->getChildren());
+            newChildrenMutable = std::make_shared<
+                std::vector<std::shared_ptr<const ShadowNode>>>(
+                node->getChildren());
             newChildren = newChildrenMutable;
           }
 
diff --git a/packages/react-native/ReactCommon/react/renderer/uimanager/UIManagerBinding.cpp b/packages/react-native/ReactCommon/react/renderer/uimanager/UIManagerBinding.cpp
@@ -413,8 +413,9 @@ jsi::Value UIManagerBinding::get(
            const jsi::Value& /*thisValue*/,
            const jsi::Value* /*arguments*/,
            size_t /*count*/) -> jsi::Value {
-          auto shadowNodeList = std::make_shared<ShadowNode::ListOfShared>(
-              ShadowNode::ListOfShared({}));
+          auto shadowNodeList =
+              std::make_shared<std::vector<std::shared_ptr<const ShadowNode>>>(
+                  std::vector<std::shared_ptr<const ShadowNode>>({}));
           return valueFromShadowNodeList(runtime, shadowNodeList);
         });
   }
diff --git a/packages/react-native/ReactCommon/react/renderer/uimanager/UIManagerUpdateShadowTree.cpp b/packages/react-native/ReactCommon/react/renderer/uimanager/UIManagerUpdateShadowTree.cpp
@@ -196,7 +196,8 @@ void UIManager::updateShadowTree(
 
         auto cloned = oldShadowNode->clone(
             {.props = newProps,
-             .children = std::make_shared<ShadowNode::ListOfShared>(children)});
+             .children = std::make_shared<
+                 std::vector<std::shared_ptr<const ShadowNode>>>(children)});
         clonedShadowNodes.insert({oldShadowNode->getTag(), std::move(cloned)});
       } else {
         LOG(ERROR) << "oldShadowNode is null";
diff --git a/packages/react-native/ReactCommon/react/renderer/uimanager/primitives.h b/packages/react-native/ReactCommon/react/renderer/uimanager/primitives.h
@@ -60,7 +60,8 @@ inline static ShadowNode::UnsharedListOfShared shadowNodeListFromValue(
     auto jsArray = std::move(object).asArray(runtime);
     size_t jsArrayLen = jsArray.length(runtime);
     if (jsArrayLen > 0) {
-      auto shadowNodeArray = std::make_shared<ShadowNode::ListOfShared>();
+      auto shadowNodeArray =
+          std::make_shared<std::vector<std::shared_ptr<const ShadowNode>>>();
       shadowNodeArray->reserve(jsArrayLen);
 
       for (size_t i = 0; i < jsArrayLen; i++) {
@@ -71,8 +72,8 @@ inline static ShadowNode::UnsharedListOfShared shadowNodeListFromValue(
       return shadowNodeArray;
     } else {
       // TODO: return ShadowNode::emptySharedShadowNodeSharedList()
-      return std::make_shared<ShadowNode::ListOfShared>(
-          ShadowNode::ListOfShared({}));
+      return std::make_shared<std::vector<std::shared_ptr<const ShadowNode>>>(
+          std::vector<std::shared_ptr<const ShadowNode>>({}));
       ;
     }
   } else {
@@ -95,7 +96,8 @@ inline static jsi::Value valueFromShadowNodeList(
 
 inline static ShadowNode::UnsharedListOfShared shadowNodeListFromWeakList(
     const ShadowNode::UnsharedListOfWeak& weakShadowNodeList) {
-  auto result = std::make_shared<ShadowNode::ListOfShared>();
+  auto result =
+      std::make_shared<std::vector<std::shared_ptr<const ShadowNode>>>();
   for (const auto& weakShadowNode : *weakShadowNodeList) {
     auto sharedShadowNode = weakShadowNode.lock();
     if (!sharedShadowNode) {
diff --git a/private/cxx-public-api/ReactNativeCPP.api b/private/cxx-public-api/ReactNativeCPP.api

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,8 @@ std::shared_ptr<const ShadowNode> findAndClone(`
`27`	`27`	`children[i] = maybeClone;`
`28`	`28`	`return node->clone(`
`29`	`29`	`{ShadowNodeFragment::propsPlaceholder(),`
`30`		`- std::make_shared<ShadowNode::ListOfShared>(children)});`
	`30`	`+ std::make_shared<std::vector<std::shared_ptr<const ShadowNode>>>(`
	`31`	`+ children)});`
`31`	`32`	`}`
`32`	`33`	`}`
`33`	`34`