Skip to content

fix arguments for merge #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2021
Merged

fix arguments for merge #61

merged 1 commit into from
May 20, 2021

Conversation

Dr-Irv
Copy link
Contributor

@Dr-Irv Dr-Irv commented May 20, 2021

Closes #60

Note that the second merge_asof() arguments was simply wrong, and that is now fixed.

jakebailey
jakebailey approved these changes May 20, 2021
View reviewed changes
Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I'll get this into Pylance for next week.

@jakebailey jakebailey merged commit e153dab into microsoft:main May 20, 2021
@Dr-Irv Dr-Irv mentioned this pull request Feb 4, 2022
Merged
@Dr-Irv Dr-Irv deleted the merge branch February 18, 2022 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakebailey jakebailey jakebailey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pd.merge allows Series as first argument
2 participants
@Dr-Irv @jakebailey