-
Notifications
You must be signed in to change notification settings - Fork 102
Pandas stub fixes #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pandas stub fixes #129
Conversation
Update .gitignore. Make some fixes based on the tests from the pandas-stubs package (more to come).
Accidental checkin
doc/pandas/core/frame.pyi.ds
Outdated
@@ -1332,7 +1333,6 @@ observed : bool, default False | |||
|
|||
Returns | |||
------- | |||
DataFrameGroupBy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DataFrameGroupBy
removed on purpose?
python-type-stubs/pandas/io/parsers.pyi Lines 553 to 564 in e7def7e
|
Change IO back to FilePathOrBuffer
@gramster this change broke stuff in
|
I don't think it's this change; there was a reversion to If you edit your
to
I think you should be good. |
@gramster even if I do the change above, then the following test fails: from io import StringIO
import pandas as pd
from pandas.io.parsers import TextFileReader
dio = StringIO("a,b\n 1,2\n 3,4\n")
df: pd.DataFrame = pd.read_csv(dio)
print(df)
dio.seek(0)
tr: pd.DataFrame = pd.read_csv(dio)
dio.seek(0)
tr2: TextFileReader = pd.read_csv(dio, iterator=True)
dio.seek(0)
tr3: pd.DataFrame = pd.read_csv(dio, iterator=False)
dio.seek(0)
tr5: TextFileReader = pd.read_csv(dio, chunksize=10)
dio.seek(0)
tr6: pd.DataFrame = pd.read_csv(dio, chunksize=None)
dio.seek(0)
tr7: pd.DataFrame = pd.read_csv(dio, header="infer")
dio.seek(0)
tr8: TextFileReader = pd.read_csv(dio, header="infer", iterator=True)
ftr1: TextFileReader = pd.read_csv("hey.csv")
ftr2: pd.DataFrame = pd.read_csv("hey.csv", iterator=True)
ftr3: TextFileReader = pd.read_csv("hey.csv", iterator=False)
ftr5: pd.DataFrame = pd.read_csv("hey.csv", chunksize=10)
ftr6: TextFileReader = pd.read_csv("he.csv", chunksize=None)
ftr7: TextFileReader = pd.read_csv("hey.csv", header="infer")
ftr8: pd.DataFrame = pd.read_csv("hey.csv", header="infer", iterator=True) All the assignments to variables starting with The deletion of the |
Add a few missing files.
Update .gitignore.
Make some fixes based on the tests from the pandas-stubs package (more to come).