cherry-pick(#21848): fix(run-server): do not engage socks when not requested

dgozman · dgozman · commit 8693fd4743db · 2023-03-21T14:09:49.000-07:00
Fixes #21762.
diff --git a/packages/playwright-core/src/remote/playwrightConnection.ts b/packages/playwright-core/src/remote/playwrightConnection.ts
@@ -226,6 +226,8 @@ export class PlaywrightConnection {
   }
 
   private async _createOwnedSocksProxy(playwright: Playwright): Promise<SocksProxy | undefined> {
+    if (!this._options.socksProxyPattern)
+      return;
     const socksProxy = new SocksProxy();
     socksProxy.setPattern(this._options.socksProxyPattern);
     playwright.options.socksProxyPort = await socksProxy.listen(0);

Original file line number	Diff line number	Diff line change
`@@ -226,6 +226,8 @@ export class PlaywrightConnection {`
`226`	`226`	`}`
`227`	`227`
`228`	`228`	`private async _createOwnedSocksProxy(playwright: Playwright): Promise<SocksProxy \| undefined> {`
	`229`	`+ if (!this._options.socksProxyPattern)`
	`230`	`+ return;`
`229`	`231`	`const socksProxy = new SocksProxy();`
`230`	`232`	`socksProxy.setPattern(this._options.socksProxyPattern);`
`231`	`233`	`playwright.options.socksProxyPort = await socksProxy.listen(0);`