Skip to content

[BUG] Frame is emitted on Page events domcontentloaded/load #1399

Closed
@YusukeIwaki

Description

@YusukeIwaki

Context:

  • Playwright Version: 1.23
  • Operating System: macOS
  • Python version: 3.9
  • Browser: Chromium

Code Snippet

from playwright.sync_api import sync_playwright, Page

with sync_playwright() as playwright:
    with playwright.chromium.launch(channel='chrome') as browser:
        page = browser.new_page()
        with page.expect_event('domcontentloaded') as event:
            page.goto('https://github.com/YusukeIwaki')
        print(event.value)

Describe the bug

The code above prints Frame in 1.23, which was Page in 1.22.
The JS version of Playwright still prints Page with the similar code, so I think this is an unexpected change.
The change would be made here: https://github.com/microsoft/playwright-python/pull/1374/files#diff-532b443f553121e300cafcb5964712250d091576e944af3b880ba143e1413c28R103

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions