2301 fold pad into conv #2363
Open
2301 fold pad into conv #2363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinchuby
reviewed
Jun 4, 2025
Johansmm
force-pushed
the
2301-fold-pad-into-conv
branch
from
4b9b69b to
19b0418
Compare
justinchuby
reviewed
Jun 4, 2025
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
justinchuby
reviewed
Jun 4, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2363 +/- ##
==========================================
+ Coverage 69.29% 69.59% +0.29%
==========================================
Files 201 203 +2
Lines 25772 26064 +292
Branches 2688 2732 +44
==========================================
+ Hits 17859 18138 +279
- Misses 6988 6995 +7
- Partials 925 931 +6 ☔ View full report in Codecov by Sentry. |
justinchuby
reviewed
Jun 4, 2025
justinchuby
reviewed
Jun 4, 2025
justinchuby
reviewed
Jun 4, 2025
justinchuby
reviewed
Jun 4, 2025
justinchuby
reviewed
Jun 4, 2025
justinchuby
reviewed
Jun 4, 2025
justinchuby
reviewed
Jun 4, 2025
justinchuby
reviewed
Jun 4, 2025
justinchuby
reviewed
Jun 4, 2025
Convert 'auto_pad' attribute into a list of explicit pads.
Johansmm
force-pushed
the
2301-fold-pad-into-conv
branch
from
19b0418 to
1604446
Compare
|
Push force rebasing on main and fixing conflicts. |
justinchuby
reviewed
Jun 24, 2025
justinchuby
reviewed
Jun 24, 2025
Johansmm
commented
Jun 24, 2025
There was a problem hiding this comment.
@justinchuby I forgot to explain in the previous message that the changes were not ready yet (just fixing rebase with main).
In the last commits I update the code with all the suggestions.
Now if this work is ready to be reviewed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fuses Pad nodes into the following nodes (Conv, ConvInteger)
(#2301)