Skip to content

Add tests for removing unused nodes in subgraphs #2265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

justinchuby
Copy link
Collaborator

@justinchuby justinchuby commented May 1, 2025


For more details, open the Copilot Workspace session.

Copy link

codecov bot commented May 1, 2025

❌ 8 Tests Failed:

Tests completed Failed Passed Skipped
5871 8 5863 3238
View the top 3 failed test(s) by shortest run time
onnxscript.ir.passes.common.unused_removal_test.RemoveUnusedTest_0::test_remove_unused_optional_outputs_in_subgraph
Stack Traces | 0.001s run time
.../passes/common/unused_removal_test.py:366: in test_remove_unused_optional_outputs_in_subgraph
    model = onnx.parser.parse_model(
..../test/lib/python3.10.../site-packages/onnx/parser.py:25: in parse_model
    raise ParseError(msg)
E   onnx.parser.ParseError: b'[ParseError at position (line: 6 column: 51)]\nError context:                 z = If (x) <then_branch=then_graph, else_branch=else_graph>\nExpected character = not found.'
onnxscript.ir.passes.common.unused_removal_test.RemoveUnusedTest_0::test_unused_inputs_in_subgraph_are_not_removed
Stack Traces | 0.001s run time
.../passes/common/unused_removal_test.py:332: in test_unused_inputs_in_subgraph_are_not_removed
    model = onnx.parser.parse_model(
..../test/lib/python3.10.../site-packages/onnx/parser.py:25: in parse_model
    raise ParseError(msg)
E   onnx.parser.ParseError: b'[ParseError at position (line: 6 column: 51)]\nError context:                 z = If (x) <then_branch=then_graph, else_branch=else_graph>\nExpected character = not found.'
onnxscript.ir.passes.common.unused_removal_test.RemoveUnusedTest_1::test_remove_unused_initializers_in_subgraph
Stack Traces | 0.001s run time
.../passes/common/unused_removal_test.py:289: in test_remove_unused_initializers_in_subgraph
    model = onnx.parser.parse_model(
..../test/lib/python3.10.../site-packages/onnx/parser.py:25: in parse_model
    raise ParseError(msg)
E   onnx.parser.ParseError: b'[ParseError at position (line: 6 column: 51)]\nError context:                 z = If (x) <then_branch=then_graph, else_branch=else_graph>\nExpected character = not found.'

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@justinchuby justinchuby marked this pull request as draft May 1, 2025 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

1 participant