[Lint] Apply lint #126
[Lint] Apply lint #126
Conversation
Move metadata into pyproject.toml [Lint] Add CI
Move metadata into pyproject.toml [Lint] Add CI
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Found 34 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Found 34 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Found 34 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Found 33 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Found 33 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Found 33 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Found 33 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Found 33 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Found 33 potential problems in the proposed changes. Check the Files changed tab for more details.
This PR basically migrates the lint and CI from ONNX to here.
1. Add lint: black, isort, mypy, and flake8
- flake8 remains basic setting as main branch.
- auto-formatter will be introduced in the next PR (#126 )
3. Add pyproject.toml (includes what was in requirements.txt, setup.cfg,
and metadata in setup.py)
- Avoiding parsing documents in setup.py can reduce bugs (version_str
was -0.1-)
- Put metadata all in one file (pyproject.toml )
- benefit: toml becomes more important in python, check
[here](https://peps.python.org/pep-0680/)
4. Add lint CI to align coding style
- `Lint / Enforce style (pull_request)` CI utilizes style.sh to do the
test
- We can only make `Lint / Enforce style (pull_request)` as required
after a reasonable transition time period
6. Continue work (actually apply lint on files) on #126
fixes #105
Co-authored-by: Ubuntu <titaiwang@titaiwanglinuxcpudev.y3zdd0j2xrqelnmezcgpqgmnte.jx.internal.cloudapp.net>
There was a problem hiding this comment.
Found 33 potential problems in the proposed changes. Check the Files changed tab for more details.
Should be merged after #120
fixes #125
auto-formatterlint.sh (feel free to add on others)NOTE: I hope this one can be quickly merged, as there are PRs being merged constantly which means endless merge conflict for this one.