Skip to content

Commit e9aa833

Browse files
committed
resolving copilot comments
1 parent a7c83f8 commit e9aa833

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

mssql_python/pybind/ddbc_bindings.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2625,9 +2625,6 @@ SQLRETURN FetchBatchData(SQLHSTMT hStmt, ColumnBuffers& buffers, py::list& colum
26252625
}
26262626
case SQL_GUID: {
26272627
SQLGUID* guidValue = &buffers.guidBuffers[col - 1][i];
2628-
// We already have the raw bytes from SQL Server in the SQLGUID struct.
2629-
// We do not need to perform any additional reordering here, as the C++
2630-
// SQLGUID struct is already laid out in the non-standard SQL Server byte order.
26312628
std::vector<char> guid_bytes(16);
26322629
std::memcpy(guid_bytes.data(), guidValue, sizeof(SQLGUID));
26332630

tests/test_004_cursor.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6896,7 +6896,7 @@ def test_insert_multiple_uuids(cursor, db_connection):
68966896
db_connection.commit()
68976897

68986898
def test_uuid_insert_with_none(cursor, db_connection):
6899-
"""Test that inserting None into a UUID column raises an error (or is handled)."""
6899+
"""Test that inserting None into a UUID column results in a NULL value and is handled correctly."""
69006900
table_name = "#pytest_uuid_none"
69016901
try:
69026902
cursor.execute(f"DROP TABLE IF EXISTS {table_name}")

0 commit comments

Comments
 (0)