Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

[template] feat(icon): export call-recording icon #585

Merged
merged 2 commits into from
Dec 10, 2018

Conversation

bmdalex
Copy link
Collaborator

@bmdalex bmdalex commented Dec 10, 2018

feat(icon): export call-recording icon

Description

This PR exports call-recording icon.

It also acts as a TEMPLATE PR for exporting Teams icons; steps are:

1. find your icons-[NAME].tsx file:

  • visually in the local doc site experience (need to build and run the project and go to http://localhost:8080/icon-viewer):
    screenshot 2018-12-10 at 14 06 32
  • find the icon at path src/themes/teams/components/Icon/svg/ProcessedIcons: src/themes/teams/components/Icon/svg/ProcessedIcons/icons-call-recording.tsx in this case

2. copy icons-[NAME].tsx file to src/themes/teams/components/Icon/svg/icons and rename it to the necessary name:

  • source: src/themes/teams/components/Icon/svg/ProcessedIcons/icons-call-recording.tsx
  • dest: src/themes/teams/components/Icon/svg/icons/callRecording.tsx

3. import and export the new icon file under desired name USING KEBAB CASE:

// ...
import callRecording from './callRecording'
// ...

export default {
  // ...
  'call-recording': callRecording,
  // ...
}

4. go back to src/themes/teams/components/Icon/svg/ProcessedIcons/icons-[NAME].tsx and add exportedAs property with the value of name of the exported icon:

in src/themes/teams/components/Icon/svg/ProcessedIcons/icons-call-recording.tsx:

export default {
  // ...
  exportedAs: 'call-recording',
}

API

<Icon name="call-recording" variables={siteVars => ({ color: siteVars.red })} />

screenshot 2018-12-10 at 13 53 33

@bmdalex bmdalex changed the title feat(icon): export call-recording icon [template] feat(icon): export call-recording icon Dec 10, 2018
@vini-gupta
Copy link

@alinais @kuzhelov @mnajdova @hughreeling @jurokapsiar
How can we add those icons which are not listed in the 'Not Exported' list of icons mentioned above. For example for desktop-sharing we use an icon which is different from the 'desktop' icon available in stardust.
Desktop icon in stardust
image
Desktop Sharing icon in Teams
image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants