This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(Button): Implementing Contrast Theme and Updating Dark Theme #381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcalvery
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
25 tasks
Codecov Report
@@ Coverage Diff @@
## master #381 +/- ##
=======================================
Coverage 91.77% 91.77%
=======================================
Files 41 41
Lines 1326 1326
Branches 168 168
=======================================
Hits 1217 1217
Misses 105 105
Partials 4 4Continue to review full report at Codecov.
|
…x/buttons-contrasttheme
Refactoring buttonVariables to use Partial utility.
bcalvery
changed the title
28 tasks
alinais
approved these changes
Nov 1, 2018
mnajdova
approved these changes
Nov 1, 2018
levithomason
reviewed
Nov 1, 2018
| maxWidth: '100%', | ||
| }), | ||
|
|
||
| // Overrides for "disabled" buttons |
There was a problem hiding this comment.
nit: next line "says" the same thing.
There was a problem hiding this comment.
We have these comments in all the file, not only here. We can consider it as part of some cleanup task.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Contrast Theme styles for Button
Contrast:
Dark:
