feat(Text): Redlining text component for Teams dark & contrast themes #317
Conversation
codepretty
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #317 +/- ##
=======================================
Coverage 89.73% 89.73%
=======================================
Files 64 64
Lines 1237 1237
Branches 180 180
=======================================
Hits 1110 1110
Misses 125 125
Partials 2 2Continue to review full report at Codecov.
|
codepretty
changed the title
| successTextColor: siteVariables.green04, | ||
| timestampTextColor: siteVariables.gray04, | ||
| timestampHoverTextColor: siteVariables.gray02, | ||
| importantTextColor: siteVariables.red, |
There was a problem hiding this comment.
can these either be sorted alphabetically or the same as each other?
There was a problem hiding this comment.
Let's also remove the duplicate Text word in each. Variables are already namespaced by display name:
theme.componentVariables.Text().successColor
|
|
||
| // | ||
| // COLORS | ||
| // | ||
| export const black = '#000' | ||
|
|
||
| export const hyperlinkColor = '#ffff01' | ||
| export const disabledColor = '#3ff23f' | ||
| export const selectionBackgroundColor = '#1aebff' |
There was a problem hiding this comment.
these may be older colors or maybe I have older color redlines... (sending image via teams)
|
|
||
| // | ||
| // COLORS | ||
| // | ||
| export const black = '#000' | ||
|
|
||
| export const hyperlinkColor = '#ffff01' | ||
| export const disabledColor = '#3ff23f' |
There was a problem hiding this comment.
This feels too generic to be useful in all color contexts. How can we have a single color for "disabled" without knowing if it is for a foreground, background, border, etc or which component it is for?
There was a problem hiding this comment.
I can rename to accessibleYellow and accessibleGreen for now. Although, maybe it should just be a general green and yellow option, like yellow0x and green0x...
Updating the colors for Text component for Teams dark & contrast themes.
Dark theme
Contrast theme
