This repository was archived by the owner on Mar 4, 2020. It is now read-only.
feat: give component examples a theme specific background #316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codepretty
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
25 tasks
levithomason
approved these changes
Oct 4, 2018
| color: siteVariables.bodyColor, | ||
| }} | ||
| > | ||
| <div dir={showRtl ? 'rtl' : undefined}>{exampleElement}</div> |
There was a problem hiding this comment.
While we're touching this area, let's hoist dir up to the Column component.
codepretty
changed the title
Codecov Report
@@ Coverage Diff @@
## master #316 +/- ##
=======================================
Coverage 89.54% 89.54%
=======================================
Files 62 62
Lines 1177 1177
Branches 152 152
=======================================
Hits 1054 1054
Misses 121 121
Partials 2 2Continue to review full report at Codecov.
|
28 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing component examples to use theme specific backgrounds
Example for Dark theme
