This repository was archived by the owner on Mar 4, 2020. It is now read-only.
Refactor alert colors to variables #2285
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hisuwh
requested review from
JasonGore,
dvdzkwsk,
dzearing,
ecraig12345,
jdhuntington,
kenotron,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
|
|
mnajdova
reviewed
Jan 31, 2020
| visibility: 'visible', | ||
|
|
||
| ...getIntentColorsFromProps(p, v, siteVariables), | ||
| ...getIntentColorsFromProps(p, v), |
Contributor
Author
|
Sorry @mnajdova are you asking me to do that? Not quite what you want me to do if so? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm doing some light theming for an application over the top of the teams theme. Most of the alert types are using variables for their colors - so these can be more easily overridden.
This is a small refactor to make this true for the success and warning states also.