This repository was archived by the owner on Mar 4, 2020. It is now read-only.
chore: remove FocusZoneMode #2265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
dvdzkwsk,
dzearing,
ecraig12345,
JasonGore,
jdhuntington,
kenotron,
levithomason,
miroslavstastny and
mnajdova
as code owners
layershifter
changed the title
layershifter
commented
Jan 23, 2020
| @@ -18,9 +17,7 @@ describe('ChatMessage', () => { | |||
| chatMessageImplementsShorthandProp('content', Box, { mapsValueToProp: 'children' }) | |||
|
|
|||
| describe('accessibility', () => { | |||
| handlesAccessibility(ChatMessage, { | |||
| focusZoneDefinition: (chatMessageBehavior as AccessibilityDefinition).focusZone, | |||
There was a problem hiding this comment.
This thing was broken as chatMessageBehavior is a function, there is no focusZone prop
Perf comparison
Generated by 🚫 dangerJS |
mnajdova
reviewed
Jan 23, 2020
mnajdova
approved these changes
Jan 23, 2020
Co-Authored-By: Marija Najdova <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGES
This PR removes:
modeproperty fromfocusZoneconfiguration accessibility behaviorsFocusZoneModeandFOCUSZONE_WRAP_ATTRIBUTEare no longer exportedMotivation
FocusZoneModeis never actually used as in all cases we usedFocusZoneMode.Embedmode. It simplifies logic underrenderComponent()and allows to have only single way to work withFocusZone. Related to #1980 as simplifiesFocusZoneintegration.