This repository was archived by the owner on Mar 4, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC: Remove
content
as part of factories/slotsAPI with having
content
&children
comes from SUIR and the goal was to create a separation between concepts: use only Children or Shorthand API 💡In the reality it creates more confusion than something useful, i.e. not everyone on consumer side understand how it works properly.
Sometimes
content
is a slot, sometimes it is aReactNode
, so you will never know what is correct way:Another one is that of our components do not implement that idea properly, i.e.
content
&children
will be rendered. During my API experiments and prototyping I found thatcontent
is useless at 🤔The best way to avoid confusion is to drop it for cases like
Header
and keep it for Popup. In this case:content
exists is always slotcontent={{ content }}
, it will becontent={{ children }}
which is more clear