fix(Dropdown): colliding toggle button and scroll #2006
Conversation
jurokapsiar
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #2006 +/- ##
=======================================
Coverage 77.01% 77.01%
=======================================
Files 158 158
Lines 5456 5456
Branches 1578 1594 +16
=======================================
Hits 4202 4202
Misses 1241 1241
Partials 13 13Continue to review full report at Codecov.
|
| @@ -106,7 +106,7 @@ const dropdownStyles: ComponentSlotStylesPrepared<DropdownPropsAndState, Dropdow | |||
| overflowY: 'auto', | |||
| maxHeight: v.selectedItemsMaxHeight, | |||
| width: '100%', | |||
| ...(p.toggleIndicator && { paddingRight: v.toggleIndicatorSize }), | |||
| ...(p.toggleIndicator && { marginRight: v.toggleIndicatorSize }), | |||
There was a problem hiding this comment.
this actually breaks IE in a strange way. Follwoing code added to the toggle indicator slot works better:
root: {
[`& .${Dropdown.slotClassNames.toggleIndicator}`]: {
marginRight: "12px"
}
}
There was a problem hiding this comment.
@jurokapsiar what is the strange behavior?
There was a problem hiding this comment.
It looks like the new styling moves the scrollbar for all browsers and not just IE11. I don't think that is what we will want, but i can't load in ie11 right nowso i don't understand the issue...
Before:
After:
