This repository was archived by the owner on Mar 4, 2020. It is now read-only.
chore: move FocusZone components to react-bindings #2004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
force-pushed
the
chore/move-focuszone
branch
from
e60a8c6 to
9663b77
Compare
layershifter
force-pushed
the
chore/move-focuszone
branch
from
9663b77 to
c755b47
Compare
Codecov Report
@@ Coverage Diff @@
## master #2004 +/- ##
==========================================
- Coverage 77.09% 76.71% -0.39%
==========================================
Files 160 160
Lines 5493 5492 -1
Branches 1603 1585 -18
==========================================
- Hits 4235 4213 -22
- Misses 1245 1266 +21
Partials 13 13
Continue to review full report at Codecov.
|
layershifter
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
Changed dependencies are detected.Changed dependencies in
Generated by 🚫 dangerJS |
layershifter
commented
Oct 4, 2019
| "@babel/runtime": "^7.1.2" | ||
| "@babel/runtime": "^7.1.2", | ||
| "@stardust-ui/accessibility": "^0.39.0", | ||
| "@stardust-ui/state": "^0.39.0" |
There was a problem hiding this comment.
These packages can't be in optional dependencies because TS will throw on typings...
layershifter
commented
Oct 4, 2019
| export const getDefinedProps = <Props extends Record<string, any>>( | ||
| props: Props, | ||
| ): Partial<Props> => { | ||
| const getDefinedProps = <Props extends Record<string, any>>(props: Props): Partial<Props> => { |
There was a problem hiding this comment.
Should not be exported, nit
layershifter
commented
Oct 4, 2019
| @@ -1,4 +1,3 @@ | |||
| // https://jsperf.com/startdust-callable | |||
layershifter
commented
Oct 4, 2019
| @@ -1,10 +1,10 @@ | |||
| import { callable } from '@stardust-ui/react-bindings' | |||
There was a problem hiding this comment.
I also have to move callable as it used in FZ
jurokapsiar
approved these changes
Oct 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↩️ Move of
FocusZoneThis PR moves
FocusZone,AutoFocusZone,FocusTrapZone, related types and utils to@stardust-ui/react-bindingsto make them reusable.The main motivation for this is too avoid circular dependency:
@stardust-ui/react-bindings=>@stardust-ui/react=>@stardust-ui/react-bindings