Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

feat(Flex): move styles to base theme #1206

Merged
merged 7 commits into from
Apr 14, 2019

Conversation

kuzhelov
Copy link
Contributor

@kuzhelov kuzhelov commented Apr 10, 2019

This PR moves Flex and Flex.Item styles to base theme

@codecov
Copy link

codecov bot commented Apr 10, 2019

Codecov Report

Merging #1206 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1206   +/-   ##
=======================================
  Coverage   82.54%   82.54%           
=======================================
  Files         751      751           
  Lines        8850     8850           
  Branches     1246     1246           
=======================================
  Hits         7305     7305           
  Misses       1530     1530           
  Partials       15       15
Impacted Files Coverage Δ
...ges/react/src/themes/base/components/Flex/utils.ts 33.33% <ø> (ø)
...eact/src/themes/base/components/Flex/flexStyles.ts 10% <ø> (ø)
packages/react/src/themes/teams/componentStyles.ts 100% <ø> (ø) ⬆️
.../src/themes/base/components/Flex/flexItemStyles.ts 16.66% <ø> (ø)
...c/themes/base/components/Flex/flexItemVariables.ts 100% <ø> (ø)
...t/src/themes/base/components/Flex/flexVariables.ts 100% <ø> (ø)
...kages/react/src/themes/teams/componentVariables.ts 100% <ø> (ø) ⬆️
...ckages/react/src/themes/base/componentVariables.ts 100% <100%> (ø) ⬆️
packages/react/src/themes/base/componentStyles.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f73c9d...5729c75. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 10, 2019

Codecov Report

Merging #1206 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1206   +/-   ##
=======================================
  Coverage   82.56%   82.56%           
=======================================
  Files         752      752           
  Lines        8859     8859           
  Branches     1246     1178   -68     
=======================================
  Hits         7314     7314           
  Misses       1530     1530           
  Partials       15       15
Impacted Files Coverage Δ
...ges/react/src/themes/base/components/Flex/utils.ts 33.33% <ø> (ø)
...eact/src/themes/base/components/Flex/flexStyles.ts 10% <ø> (ø)
packages/react/src/themes/teams/componentStyles.ts 100% <ø> (ø) ⬆️
...kages/react/src/themes/teams/componentVariables.ts 100% <ø> (ø) ⬆️
.../src/themes/base/components/Flex/flexItemStyles.ts 16.66% <ø> (ø)
...c/themes/base/components/Flex/flexItemVariables.ts 100% <ø> (ø)
...t/src/themes/base/components/Flex/flexVariables.ts 100% <ø> (ø)
...ckages/react/src/themes/base/componentVariables.ts 100% <100%> (ø) ⬆️
packages/react/src/themes/base/componentStyles.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b85c3ab...5f0e96d. Read the comment docs.

Copy link
Contributor

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the changelog please

Copy link
Collaborator

@bmdalex bmdalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kuzhelov kuzhelov merged commit f75141e into master Apr 14, 2019
@delete-merged-branch delete-merged-branch bot deleted the feat/move-flex-styles-to-base-theme branch April 14, 2019 20:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants