-
Notifications
You must be signed in to change notification settings - Fork 53
fix(RadioGroup): use regular components instead of Label #1070
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1070 +/- ##
==========================================
- Coverage 81.9% 81.89% -0.01%
==========================================
Files 693 693
Lines 8448 8447 -1
Branches 1233 1163 -70
==========================================
- Hits 6919 6918 -1
Misses 1514 1514
Partials 15 15
Continue to review full report at Codecov.
|
{rtlTextContainer.createFor({ element: label })} | ||
</Label> | ||
</ElementType> | ||
{Box.create(label, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we change the type of the label
prop to ShorthandValue
?
CHANGELOG.md
Outdated
@@ -16,6 +16,7 @@ | |||
This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | |||
|
|||
## [Unreleased] | |||
- Use regular components instead of `Label` in `RadioGroupItem` @layershifter ([#XXX](https://github.com/stardust-ui/react/pull/XXX)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add section above this (Breaking change probably if we introduce changes of the typings)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with readers. And it looks good :) 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good. Be sure to fix the screener regressions before merging.
Fixes #1040.
BREAKING CHANGES
Before
After
label
is now shorthand value, see Shorthand Props