Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

Commit dbcd0dc

Browse files
committed
- removed redundant open flag
- reordered handlers and render function
1 parent ac31952 commit dbcd0dc

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

docs/src/examples/components/Dropdown/Usage/DropdownExampleControlled.shorthand.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@ const inputItems = ['Bruce Wayne', 'Natasha Romanoff', 'Steven Strange', 'Alfred
66
class DropdownExampleControlled extends React.Component {
77
state = { open: false }
88

9+
handleOpenChange = (e, { open }) => {
10+
this.setState({ open })
11+
}
12+
913
render() {
1014
const open = this.state.open
1115
return (
@@ -20,10 +24,6 @@ class DropdownExampleControlled extends React.Component {
2024
</Flex>
2125
)
2226
}
23-
24-
handleOpenChange = (e, { open }) => {
25-
this.setState({ open })
26-
}
2727
}
2828

2929
export default DropdownExampleControlled

packages/react/src/components/Dropdown/Dropdown.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -384,7 +384,6 @@ class Dropdown extends AutoControlledComponent<Extendable<DropdownProps>, Dropdo
384384
{this.renderItemsList(
385385
styles,
386386
variables,
387-
open,
388387
highlightedIndex,
389388
toggleMenu,
390389
selectItemAtIndex,
@@ -475,7 +474,6 @@ class Dropdown extends AutoControlledComponent<Extendable<DropdownProps>, Dropdo
475474
private renderItemsList(
476475
styles: ComponentSlotStylesInput,
477476
variables: ComponentVariablesInput,
478-
open: boolean,
479477
highlightedIndex: number,
480478
toggleMenu: () => void,
481479
selectItemAtIndex: (index: number) => void,
@@ -484,6 +482,7 @@ class Dropdown extends AutoControlledComponent<Extendable<DropdownProps>, Dropdo
484482
getInputProps: (options?: GetInputPropsOptions) => any,
485483
) {
486484
const { search } = this.props
485+
const { open } = this.state
487486
const { innerRef, ...accessibilityMenuProps } = getMenuProps(
488487
{ refKey: 'innerRef' },
489488
{ suppressRefError: true },

0 commit comments

Comments
 (0)