address latest PR feedback

Author: sebastianburckhardt

src/Worker/Grpc/GrpcDurableTaskWorker.Processor.cs

@@ -30,14 +30,14 @@ class Processor
         readonly GrpcDurableTaskWorker worker;
         readonly TaskHubSidecarServiceClient client;
         readonly DurableTaskShimFactory shimFactory;
-        readonly InternalOptions internalOptions;
+        readonly GrpcDurableTaskWorkerOptions.InternalOptions internalOptions;
 
         public Processor(GrpcDurableTaskWorker worker, TaskHubSidecarServiceClient client)
         {
             this.worker = worker;
             this.client = client;
             this.shimFactory = new DurableTaskShimFactory(this.worker.grpcOptions, this.worker.loggerFactory);
-            this.internalOptions = this.worker.grpcOptions.InternalOptions;
+            this.internalOptions = this.worker.grpcOptions.Internal;
         }
 
         ILogger Logger => this.worker.logger;

src/Worker/Grpc/GrpcDurableTaskWorkerOptions.cs

@@ -24,7 +24,26 @@ public sealed class GrpcDurableTaskWorkerOptions : DurableTaskWorkerOptions
     public CallInvoker? CallInvoker { get; set; }
 
     /// <summary>
-    /// Gets or sets the internal protocol options. These are used to control backend-dependent features.
+    /// Gets the internal protocol options. These are used to control backend-dependent features.
     /// </summary>
-    internal InternalOptions Internal { get; set; } = new();
+    internal InternalOptions Internal { get; } = new();
+
+    /// <summary>
+    /// Internal options are not exposed directly, but configurable via <see cref="Internal.InternalOptionsExtensions"/>.
+    /// </summary>
+    internal class InternalOptions
+    {
+        /// <summary>
+        /// Gets or sets a value indicating whether entity-related events appearing in orchestration histories should be
+        /// automatically converted back and forth between the old DT Core representation (JSON-encoded external events)
+        /// and the new protobuf representation (explicit history events), which is used by the DTS scheduler backend.
+        /// </summary>
+        public bool ConvertOrchestrationEntityEvents { get; set; }
+
+        /// <summary>
+        /// Gets or sets a value indicating whether to automatically add entity
+        /// unlock events into the history when an orchestration terminates while holding an entity lock.
+        /// </summary>
+        public bool InsertEntityUnlocksOnCompletion { get; set; }
+    }
 }

src/Worker/Grpc/InternalOptionsExtensions.cs renamed to src/Worker/Grpc/Internal/InternalOptionsExtensions.cs

@@ -16,9 +16,15 @@ public static class InternalOptionsExtensions
     /// Configure the worker to use the default settings for connecting to the Azure Managed Durable Task service.
     /// </summary>
     /// <param name="options">The gRPC worker options.</param>
+    /// <remarks>
+    /// This is an internal API that supports the DurableTask infrastructure and not subject to
+    /// the same compatibility standards as public APIs. It may be changed or removed without notice in
+    /// any release. You should only use it directly in your code with extreme caution and knowing that
+    /// doing so can result in application failures when updating to a new DurableTask release.
+    /// </remarks>
     public static void ConfigureForAzureManaged(this GrpcDurableTaskWorkerOptions options)
     {
-        options.InternalOptions.ConvertOrchestrationEntityEvents = true;
-        options.InternalOptions.InsertEntityUnlocksOnCompletion = true;
+        options.Internal.ConvertOrchestrationEntityEvents = true;
+        options.Internal.InsertEntityUnlocksOnCompletion = true;
     }
 }