Skip to content

Do not resolve alias when getting symbol of import equal's right hand side #8789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2016
Merged

Do not resolve alias when getting symbol of import equal's right hand side #8789

merged 1 commit into from
May 27, 2016

Conversation

sheetalkamat
Copy link
Member

This helps searching correct symbols when renaming.
Fixes #5501

@mhegazy
Copy link
Contributor

mhegazy commented May 25, 2016

thanks, we should have added this a while back. we now add Alias to lookup flags, in places like in getSymbolOfEntityNameOrPropertyAccessExpression, so we should remove these too. but that can be in a different PR.

@mhegazy
Copy link
Contributor

mhegazy commented May 25, 2016

👍

@sheetalkamat sheetalkamat merged commit 3515652 into master May 27, 2016
@sheetalkamat sheetalkamat deleted the getSymbolAtAliasLocation branch May 27, 2016 16:27
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sheetalkamat @mhegazy @msftclas