Declared type as initial type in control flow analysis #8429
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we consider the initial type of a variable to be a union of its declared type and
undefined
. This makes control flow based type analysis less aggressive in cases where the checker is unable to see assignments to a variable because they exclusively occur in nested functions (which aren't included in the analysis). For example:With the PR we consider the initial type of
result
to beFoo | undefined
, which narrows toFoo
in the type guard. Previously we considered the initial type to beundefined
which would narrow tonothing
and cause errors.