Fix for issue #712 #823
Fix for issue #712 #823
Conversation
| @@ -5090,6 +5098,23 @@ module ts { | |||
| case SyntaxKind.CommaToken: | |||
| return rightType; | |||
| } | |||
|
|
|||
| // if a user tries to apply an innappropriate operator to 2 boolean operands try and return them a helpful suggestion | |||
There was a problem hiding this comment.
Change this to "a bitwise operator" and split this into two lines.
|
I don't see any tests affected that demonstrate the change for compound assignment. You may want to add a test in either |
| if ((leftType.flags & TypeFlags.Boolean) && (rightType.flags & TypeFlags.Boolean) && (suggestedOperator = getSuggestedBooleanOperator(node.operator)) !== undefined) { | ||
| error(node, Diagnostics.The_0_operator_is_not_allowed_for_boolean_types_Consider_using_1_instead, tokenToString(node.operator), tokenToString(suggestedOperator)); | ||
| } | ||
| // otherwise just check each operand seperately and report errors as normal |
There was a problem hiding this comment.
please don't place comments above 'else' blocks. Just put it inside the else block. Thanks!
|
Chris, this LGTM. Thanks for contributing. I'm not sure if you are approved for submitting to TS yet. You'll have to talk to @mhegazy about the necessary paperwork to contribute. Once that goes through, then we can proceed on this. Thanks! |
|
@CyrusNajmabadi I actually work at MS and after talking with @mhegazy it looks like I don't have to fill out the official paperwork. |
| error(node, Diagnostics.The_0_operator_is_not_allowed_for_boolean_types_Consider_using_1_instead, tokenToString(node.operator), tokenToString(suggestedOperator)); | ||
| } | ||
| else { | ||
| // otherwise just check each operand seperately and report errors as normal |
There was a problem hiding this comment.
Misspelled "separately"
|
👍 after that last change is addressed, thanks Chris! |
|
thanks! |
…atorsOnBooleans Fix for issue #712
Fix for issue #712. The specific issue mentioned there concerns providing a more helpful error message when the ^ operator is used with 2 boolean operands. My change is slightly more general in that it generates an error for &, &=, ^, ^=, |, and |=. I used the error message mentioned in the issue:
"error TS0000: The ^ operator is not allowed for boolean types. Consider using !== instead."
When & or | are used with boolean values I suggest && and || respectively.
One interesting thing here is how to handle the assignment operators. Right now I show the same recommendation i.e. "consider using !==" shows up for both "^" and "^=" which, is maybe a bit confusing, but I wasn't sure the best way to do this. I've spoken briefly with @DanielRosenwasser about this but would be open to any other feedback for how to handle this.