Fix incorrect emit for JSX/React #7823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
does this incur any changes in test baselines? |
|
No, it fixes the emit to match existing baselines. |
|
👍 |
1 similar comment
|
👍 |
|
🚢 🇮🇹 |
| @@ -528,12 +528,16 @@ const _super = (function (geti, seti) { | |||
| // JSX (non-expression) | |||
There was a problem hiding this comment.
Minor: should this comment be updated? Since the SyntaxKind that it will print is JsxExpression
There was a problem hiding this comment.
JsxExpression is not an expression, you can't put it in a CommaExpression for example. Rather its more like ExpressionStatement, it represents a different part of the tree that contains an expression. The fact that it inherits from Expression is a red-herring and one of the reasons I wrote this incorrectly in the first place.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some issues in the jsx transform and pretty printer that were causing a significant number of tests to fail revolving around JSX and React emit.
CC: @vladima, @DanielRosenwasser, @yuit