Skip to content

Accepts nominal baseline changes for some failing tests. #7822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions tests/baselines/reference/FunctionDeclaration10_es6.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ function * foo(a = yield => yield) {
}

//// [FunctionDeclaration10_es6.js]
function* foo(a) {
if (a === void 0) { a = (yield); }
}
yield;
{
}
2 changes: 1 addition & 1 deletion tests/baselines/reference/FunctionDeclaration11_es6.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@ function * yield() {
}

//// [FunctionDeclaration11_es6.js]
function yield() {
function* yield() {
}
2 changes: 1 addition & 1 deletion tests/baselines/reference/FunctionDeclaration12_es6.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
var v = function * yield() { }

//// [FunctionDeclaration12_es6.js]
var v = , yield = function () { };
var v = function* () { }, yield = function () { };
2 changes: 1 addition & 1 deletion tests/baselines/reference/FunctionDeclaration13_es6.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ function * foo() {


//// [FunctionDeclaration13_es6.js]
function foo() {
function* foo() {
// Legal to use 'yield' in a type context.
var v;
}
2 changes: 1 addition & 1 deletion tests/baselines/reference/FunctionDeclaration1_es6.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@ function * foo() {
}

//// [FunctionDeclaration1_es6.js]
function foo() {
function* foo() {
}
1 change: 1 addition & 0 deletions tests/baselines/reference/FunctionDeclaration5_es6.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ function*foo(yield) {
}

//// [FunctionDeclaration5_es6.js]
function* foo() { }
yield;
{
}
2 changes: 1 addition & 1 deletion tests/baselines/reference/FunctionDeclaration6_es6.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@ function*foo(a = yield) {
}

//// [FunctionDeclaration6_es6.js]
function foo(a) {
function* foo(a) {
if (a === void 0) { a = yield; }
}
4 changes: 2 additions & 2 deletions tests/baselines/reference/FunctionDeclaration7_es6.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ function*bar() {
}

//// [FunctionDeclaration7_es6.js]
function bar() {
function* bar() {
// 'yield' here is an identifier, and not a yield expression.
function foo(a) {
function* foo(a) {
if (a === void 0) { a = yield; }
}
}
2 changes: 1 addition & 1 deletion tests/baselines/reference/FunctionDeclaration9_es6.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ function * foo() {
}

//// [FunctionDeclaration9_es6.js]
function foo() {
function* foo() {
var v = (_a = {}, _a[yield] = foo, _a);
var _a;
}
2 changes: 1 addition & 1 deletion tests/baselines/reference/FunctionExpression1_es6.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
var v = function * () { }

//// [FunctionExpression1_es6.js]
var v = function () { };
var v = function* () { };
2 changes: 1 addition & 1 deletion tests/baselines/reference/FunctionExpression2_es6.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
var v = function * foo() { }

//// [FunctionExpression2_es6.js]
var v = function foo() { };
var v = function* foo() { };
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
var v = { *foo() { } }

//// [FunctionPropertyAssignments1_es6.js]
var v = { foo: function () { } };
var v = { foo: function* () { } };
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
var v = { *() { } }

//// [FunctionPropertyAssignments2_es6.js]
var v = { : function () { } };
var v = { : function* () { } };
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
var v = { *{ } }

//// [FunctionPropertyAssignments3_es6.js]
var v = { : function () { } };
var v = { : function* () { } };
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
var v = { * }

//// [FunctionPropertyAssignments4_es6.js]
var v = { : function () { } };
var v = {};
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
var v = { *[foo()]() { } }

//// [FunctionPropertyAssignments5_es6.js]
var v = (_a = {}, _a[foo()] = function () { }, _a);
var v = (_a = {}, _a[foo()] = function* () { }, _a);
var _a;
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@ class C {
var C = (function () {
function C() {
}
C.prototype.foo = function () { };
C.prototype.foo = function* () { };
return C;
}());
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@ class C {
var C = (function () {
function C() {
}
C.prototype.foo = function () { };
C.prototype.foo = function* () { };
return C;
}());
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@ class C {
var C = (function () {
function C() {
}
C.prototype[foo] = function () { };
C.prototype[foo] = function* () { };
return C;
}());
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@ class C {
var C = (function () {
function C() {
}
C.prototype. = function () { };
C.prototype. = function* () { };
return C;
}());
16 changes: 8 additions & 8 deletions tests/baselines/reference/anonymousDefaultExportsSystem.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,28 +7,28 @@ export default class {}
export default function() {}

//// [a.js]
System.register([], function(exports_1, context_1) {
System.register([], function (exports_1, context_1) {
"use strict";
var __moduleName = context_1 && context_1.id;
var default_1;
return {
setters:[],
execute: function() {
setters: [],
execute: function () {
default_1 = class {
};
exports_1("default", default_1);
}
}
};
});
//// [b.js]
System.register([], function(exports_1, context_1) {
System.register([], function (exports_1, context_1) {
"use strict";
var __moduleName = context_1 && context_1.id;
function default_1() { }
exports_1("default", default_1);
return {
setters:[],
execute: function() {
setters: [],
execute: function () {
}
}
};
});
12 changes: 6 additions & 6 deletions tests/baselines/reference/anonymousDefaultExportsUmd.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,29 +7,29 @@ export default class {}
export default function() {}

//// [a.js]
(function (factory) {
(function (dependencies, factory) {
if (typeof module === 'object' && typeof module.exports === 'object') {
var v = factory(require, exports); if (v !== undefined) module.exports = v;
}
else if (typeof define === 'function' && define.amd) {
define(["require", "exports"], factory);
define(dependencies, factory);
}
})(function (require, exports) {
})(["require", "exports"], function (require, exports) {
"use strict";
class default_1 {
}
Object.defineProperty(exports, "__esModule", { value: true });
exports.default = default_1;
});
//// [b.js]
(function (factory) {
(function (dependencies, factory) {
if (typeof module === 'object' && typeof module.exports === 'object') {
var v = factory(require, exports); if (v !== undefined) module.exports = v;
}
else if (typeof define === 'function' && define.amd) {
define(["require", "exports"], factory);
define(dependencies, factory);
}
})(function (require, exports) {
})(["require", "exports"], function (require, exports) {
"use strict";
function default_1() { }
Object.defineProperty(exports, "__esModule", { value: true });
Expand Down
6 changes: 3 additions & 3 deletions tests/baselines/reference/asOperator3.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ var g = tag `Hello ${123} World` as string;
var h = tag `Hello` as string;

//// [asOperator3.js]
var a = "" + 123 + 456;
var b = "leading " + 123 + 456;
var a = "" + (123 + 456);
var b = "leading " + (123 + 456);
var c = 123 + 456 + " trailing";
var d = ("Hello " + 123 + " World");
var d = "Hello " + 123 + " World";
var e = "Hello";
var f = 1 + (1 + " end of string");
var g = (_a = ["Hello ", " World"], _a.raw = ["Hello ", " World"], tag(_a, 123));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -134,21 +134,21 @@ false = Math.pow(false, value);
}
value;
// array literals
['', ''] = Math.pow(['', ''], value);
_a = Math.pow(['', ''], value), "" = _a[0], "" = _a[1];
// super
var Derived = (function (_super) {
__extends(Derived, _super);
function Derived() {
_super.call(this);
(_a = _super.prototype, _a. = Math.pow(_a., value));
(_a = _super.prototype). = Math.pow(_a., value);
var _a;
}
Derived.prototype.foo = function () {
(_a = _super.prototype, _a. = Math.pow(_a., value));
(_a = _super.prototype). = Math.pow(_a., value);
var _a;
};
Derived.sfoo = function () {
(_a = _super, _a. = Math.pow(_a., value));
(_a = _super). = Math.pow(_a., value);
var _a;
};
return Derived;
Expand All @@ -175,3 +175,4 @@ foo() = Math.pow(foo(), value);
([]) = Math.pow(([]), value);
(function baz1() { }) = Math.pow((function baz1() { }), value);
(foo()) = Math.pow((foo()), value);
var _a;
4 changes: 2 additions & 2 deletions tests/baselines/reference/computedPropertyNames29_ES6.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@ class C {
//// [computedPropertyNames29_ES6.js]
class C {
bar() {
(() => {
() => {
var obj = {
[this.bar()]() { } // needs capture
};
});
};
return 0;
}
}
4 changes: 2 additions & 2 deletions tests/baselines/reference/computedPropertyNames30_ES6.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,13 @@ class Base {
class C extends Base {
constructor() {
super();
(() => {
() => {
var obj = {
// Ideally, we would capture this. But the reference is
// illegal, and not capturing this is consistent with
//treatment of other similar violations.
[(super(), "prop")]() { }
};
});
};
}
}
4 changes: 2 additions & 2 deletions tests/baselines/reference/computedPropertyNames31_ES6.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,11 @@ class Base {
}
class C extends Base {
foo() {
(() => {
() => {
var obj = {
[super.bar()]() { } // needs capture
};
});
};
return 0;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,14 @@ var __decorate = (this && this.__decorate) || function (decorators, target, key,
else for (var i = decorators.length - 1; i >= 0; i--) if (d = decorators[i]) r = (c < 3 ? d(r) : c > 3 ? d(target, key, r) : d(target, key)) || r;
return c > 3 && r && Object.defineProperty(target, key, r), r;
};
(function (factory) {
(function (dependencies, factory) {
if (typeof module === 'object' && typeof module.exports === 'object') {
var v = factory(require, exports); if (v !== undefined) module.exports = v;
}
else if (typeof define === 'function' && define.amd) {
define(["require", "exports"], factory);
define(dependencies, factory);
}
})(function (require, exports) {
})(["require", "exports"], function (require, exports) {
"use strict";
var decorator;
let Foo = class Foo {
Expand All @@ -45,14 +45,14 @@ var __decorate = (this && this.__decorate) || function (decorators, target, key,
else for (var i = decorators.length - 1; i >= 0; i--) if (d = decorators[i]) r = (c < 3 ? d(r) : c > 3 ? d(target, key, r) : d(target, key)) || r;
return c > 3 && r && Object.defineProperty(target, key, r), r;
};
(function (factory) {
(function (dependencies, factory) {
if (typeof module === 'object' && typeof module.exports === 'object') {
var v = factory(require, exports); if (v !== undefined) module.exports = v;
}
else if (typeof define === 'function' && define.amd) {
define(["require", "exports"], factory);
define(dependencies, factory);
}
})(function (require, exports) {
})(["require", "exports"], function (require, exports) {
"use strict";
var decorator;
let default_1 = class {
Expand Down
16 changes: 10 additions & 6 deletions tests/baselines/reference/decoratorMetadata.js
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,16 @@ var MyComponent = (function () {
return MyComponent;
}());
__decorate([
decorator,
__metadata('design:type', Function),
__metadata('design:paramtypes', [Object]),
__metadata('design:returntype', void 0)
decorator,
__metadata("design:typeinfo", {
type: function () { return Function; },
paramTypes: function () { return [Object]; },
returnType: function () { return void 0; }
})
], MyComponent.prototype, "method", null);
MyComponent = __decorate([
decorator,
__metadata('design:paramtypes', [service_1.default])
decorator,
__metadata("design:typeinfo", {
paramTypes: function () { return [service_1.default]; }
})
], MyComponent);
2 changes: 1 addition & 1 deletion tests/baselines/reference/decoratorOnClass8.es6.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ var __decorate = (this && this.__decorate) || function (decorators, target, key,
else for (var i = decorators.length - 1; i >= 0; i--) if (d = decorators[i]) r = (c < 3 ? d(r) : c > 3 ? d(target, key, r) : d(target, key)) || r;
return c > 3 && r && Object.defineProperty(target, key, r), r;
};
let default_1 = class {
let default_1 = class default_1 {
};
default_1.y = 1;
default_1 = __decorate([
Expand Down
Loading