revert changes in the signature of 'convertCompilerOptionsFromJson' #7595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a new APISample test for these ones. something like https://github.com/Microsoft/TypeScript/blob/master/tests/cases/compiler/APISample_compile.ts to make sure we do not break it again. |
|
👍 |
vladima
added a commit
that referenced
this pull request
Mar 21, 2016
…mJson revert changes in the signature of 'convertCompilerOptionsFromJson'
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes breaking change in API reported here.
We need to enable tests that will verify that there are no unexpected changed in the public surface of the API. I'll do this in a separate PR;