Skip to content

Declaration emit fixes #7392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 4, 2016
Merged

Declaration emit fixes #7392

merged 5 commits into from
Mar 4, 2016

Conversation

mhegazy
Copy link
Contributor

@mhegazy mhegazy commented Mar 4, 2016

Fixes #7173, #5651, #3810, #4506
each commit contains an isolated fix, most are one-liners.

@vladima
Copy link
Contributor

vladima commented Mar 4, 2016

👍 with comment

@mhegazy
Copy link
Contributor Author

mhegazy commented Mar 4, 2016

@vladima , checked the array length, and used unknownType, that seemed more uniform with other writer functions.

@vladima
Copy link
Contributor

vladima commented Mar 4, 2016

👍

mhegazy added a commit that referenced this pull request Mar 4, 2016
@mhegazy mhegazy merged commit a535460 into master Mar 4, 2016
@mhegazy mhegazy deleted the declarationEmitFixes branch March 4, 2016 23:35
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emits undefined for unknown types in declaration file
3 participants