Skip to content

Don't crash if there's no JSX.Element during SFC resolution #7308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2016

Conversation

RyanCavanaugh
Copy link
Member

Fixes #7286

@@ -2,9 +2,12 @@
// @declaration: true

namespace JSX {
interface IntrinsicElements {
export interface IntrinsicElements {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this change to export and why add export interface Element? Does this somehow make them undefined for this test?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test was invalid because IntrinsicElements wasn't actually exposed to the code below

@mhegazy
Copy link
Contributor

mhegazy commented Mar 1, 2016

👍

RyanCavanaugh added a commit that referenced this pull request Mar 1, 2016
Don't crash if there's no JSX.Element during SFC resolution
@RyanCavanaugh RyanCavanaugh merged commit c531fcb into microsoft:master Mar 1, 2016
@RyanCavanaugh RyanCavanaugh deleted the fix7286 branch March 1, 2016 18:12
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants