Don't crash when return type jsdoc tag is malformed #6709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -10344,7 +10344,7 @@ namespace ts { | |||
|
|
|||
| function getReturnTypeFromJSDocComment(func: SignatureDeclaration | FunctionDeclaration): Type { | |||
| const returnTag = getJSDocReturnTag(func); | |||
| if (returnTag) { | |||
| if (returnTag && returnTag.typeExpression) { | |||
| return getTypeFromTypeNode(returnTag.typeExpression.type); | |||
| } | |||
There was a problem hiding this comment.
Can you explicitly return undefined?
There was a problem hiding this comment.
Or should you be returning the unknownType instead?
| //// x - /**/a1() | ||
|
|
||
| goTo.marker(); | ||
| verify.quickInfoExists(); |
There was a problem hiding this comment.
Can we also verify that the quickinfo still correctly contains the first line of the comment?
There was a problem hiding this comment.
Verified manually since Fourslash is currently really bad at that
|
Couple of minor comments, else 👍 |
|
👍 |
RyanCavanaugh
added a commit
that referenced
this pull request
Feb 2, 2016
Don't crash when return type jsdoc tag is malformed
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6662