Images in Language Specification #6144
Conversation
| @@ -47,6 +47,7 @@ function convertDocumentToMarkdown(doc) { | |||
| var tableColumnCount; | |||
| var tableCellIndex; | |||
| var columnAlignment = []; | |||
| var imageCount = 0; | |||
There was a problem hiding this comment.
I don't see this in the original .ts.
|
Can we remove the generated Also, where exactly are you saving the images themselves? It's not clear from the code here. |
|
agree with @DanielRosenwasser about removing generated javascript file. |
| var level = 1; | ||
| var sectionBreak = text.indexOf("\x0C") >= 0; | ||
|
|
||
| text = trimEndFormattingMarks(text); | ||
| if (text === "/") { |
There was a problem hiding this comment.
What exactly does this mean? Can you leave a comment with the explanation?
There was a problem hiding this comment.
Sure, I will add a comment. An inline image shows up in the text just as a "/". When I see a paragraph consisting of nothing but "/", I check to see if the paragraph contains hidden text and if so I emit that instead. The hidden text is assumed to contain an appropriate markdown image link. I could look at automatically extracting the images, but I'm not sure how much time I want to sink into further exploring the Word object model.
|
I get that, I'm more curious as to what in the code exactly does that. Was extracting images out a manual process, or is it automated now? As long as we're generally confident we won't be adding more images, either is fine. |
|
👍 |
Images in Language Specification
Fixes #1566.