Pad object literal types with implicit anys based on binding pattern elements #59924

Andarist · 2024-09-10T09:45:47Z

fixes #59920 (a regression)

…elements

jakebailey · 2024-09-10T14:43:40Z

typescript-bot · 2024-09-10T14:43:43Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started
`user test this`	✅ Started
`run dt`	✅ Started
`perf test this faster`	✅ Started	👀 Results

src/compiler/checker.ts

typescript-bot · 2024-09-10T15:23:36Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,667k (± 0.91%)}	_{193,662k (± 0.91%)}	_~	_192,404k	_195,934k	_{p=0.873 n=6}
_{Parse Time}	_{1.31s (± 0.31%)}	_{1.31s (± 0.84%)}	_~	_1.29s	_1.32s	_{p=0.445 n=6}
_{Bind Time}	_0.71s	_0.71s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.59s (± 0.47%)}	_{9.57s (± 0.34%)}	_~	_9.53s	_9.62s	_{p=0.628 n=6}
_{Emit Time}	_{2.72s (± 0.28%)}	_{2.71s (± 1.82%)}	_~	_2.61s	_2.75s	_{p=0.867 n=6}
_{Total Time}	_{14.33s (± 0.35%)}	_{14.30s (± 0.41%)}	_~	_14.20s	_14.37s	_{p=0.335 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₇	₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_945,753	_945,753	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,067	_410,067	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,222,723k (± 0.00%)}	_{1,222,737k (± 0.00%)}	_~	_1,222,703k	_1,222,773k	_{p=0.423 n=6}
_{Parse Time}	_{6.65s (± 0.47%)}	_{6.62s (± 0.34%)}	_{-0.04s (- 0.53%)}	_6.59s	_6.64s	_{p=0.042 n=6}
_{Bind Time}	_{1.85s (± 0.74%)}	_{1.86s (± 0.34%)}	_~	_1.85s	_1.87s	_{p=0.388 n=6}
_{Check Time}	_{31.15s (± 0.33%)}	_{31.09s (± 0.44%)}	_~	_30.84s	_31.23s	_{p=0.630 n=6}
_{Emit Time}	_{15.03s (± 0.44%)}	_{15.04s (± 0.43%)}	_~	_14.96s	_15.14s	_{p=0.688 n=6}
_{Total Time}	_{54.68s (± 0.16%)}	_{54.62s (± 0.28%)}	_~	_54.39s	_54.82s	_{p=0.521 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,515,538	_2,515,538	_~	_~	_~	_{p=1.000 n=6}
_Types	_933,020	_933,020	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,350,322k (± 0.00%)}	_{2,350,340k (± 0.00%)}	_~	_2,350,232k	_2,350,477k	_{p=0.936 n=6}
_{Parse Time}	_{9.41s (± 0.24%)}	_{9.41s (± 0.16%)}	_~	_9.39s	_9.43s	_{p=1.000 n=6}
_{Bind Time}	_{2.18s (± 0.45%)}	_{2.17s (± 0.50%)}	_~	_2.16s	_2.18s	_{p=0.246 n=6}
_{Check Time}	_{73.19s (± 0.39%)}	_{72.80s (± 0.63%)}	_~	_72.11s	_73.29s	_{p=0.128 n=6}
_{Emit Time}	_{0.28s (± 1.99%)}	_{0.28s (± 1.47%)}	_~	_0.27s	_0.28s	_{p=0.282 n=6}
_{Total Time}	_{85.06s (± 0.32%)}	_{84.67s (± 0.54%)}	_~	_83.99s	_85.14s	_{p=0.128 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,250,213	_1,250,213	_~	_~	_~	_{p=1.000 n=6}
_Types	_265,146	_265,146	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,403,570k (± 0.04%)}	_{2,403,348k (± 0.03%)}	_~	_2,402,425k	_2,404,759k	_{p=0.689 n=6}
_{Parse Time}	_{5.08s (± 0.64%)}	_{5.10s (± 1.01%)}	_~	_5.06s	_5.18s	_{p=0.810 n=6}
_{Bind Time}	_{1.91s (± 0.86%)}	_{1.91s (± 0.61%)}	_~	_1.89s	_1.92s	_{p=0.868 n=6}
_{Check Time}	_{34.91s (± 0.34%)}	_{34.84s (± 0.16%)}	_~	_34.74s	_34.89s	_{p=0.575 n=6}
_{Emit Time}	_{3.36s (± 4.32%)}	_{3.30s (± 1.16%)}	_~	_3.25s	_3.36s	_{p=0.471 n=6}
_{Total Time}	_{45.26s (± 0.50%)}	_{45.15s (± 0.16%)}	_~	_45.07s	_45.28s	_{p=0.378 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,250,213	_1,250,213	_~	_~	_~	_{p=1.000 n=6}
_Types	_265,146	_265,146	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,477,132k (± 0.04%)}	_{2,477,505k (± 0.06%)}	_~	_2,475,876k	_2,479,267k	_{p=0.810 n=6}
_{Parse Time}	_{6.33s (± 1.03%)}	_{6.34s (± 0.48%)}	_~	_6.30s	_6.38s	_{p=0.748 n=6}
_{Bind Time}	_{2.05s (± 0.67%)}	_{2.03s (± 0.85%)}	_~	_2.01s	_2.06s	_{p=0.142 n=6}
_{Check Time}	_{41.41s (± 0.64%)}	_{41.25s (± 0.24%)}	_~	_41.11s	_41.38s	_{p=0.230 n=6}
_{Emit Time}	_{4.08s (± 3.95%)}	_{4.04s (± 3.62%)}	_~	_3.89s	_4.25s	_{p=0.689 n=6}
_{Total Time}	_{53.89s (± 0.66%)}	_{53.69s (± 0.43%)}	_~	_53.43s	_54.02s	_{p=0.298 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_259,449	_259,449	_~	_~	_~	_{p=1.000 n=6}
_Types	_105,986	_105,986	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{433,803k (± 0.01%)}	_{433,865k (± 0.04%)}	_~	_433,647k	_434,160k	_{p=0.575 n=6}
_{Parse Time}	_{3.44s (± 0.75%)}	_{3.45s (± 0.54%)}	_~	_3.41s	_3.46s	_{p=0.511 n=6}
_{Bind Time}	_{1.28s (± 0.40%)}	_{1.28s (± 0.32%)}	_~	_1.27s	_1.28s	_{p=0.595 n=6}
_{Check Time}	_{18.12s (± 0.11%)}	_{18.09s (± 0.43%)}	_~	_17.95s	_18.17s	_{p=0.627 n=6}
_{Emit Time}	_{1.66s (± 1.04%)}	_{1.64s (± 1.18%)}	_~	_1.62s	_1.67s	_{p=0.090 n=6}
_{Total Time}	_{24.48s (± 0.14%)}	_{24.46s (± 0.35%)}	_~	_24.29s	_24.53s	_{p=0.809 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₆₈	₆₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,018	_225,018	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,249	_94,249	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{370,280k (± 0.03%)}	_{370,232k (± 0.02%)}	_~	_370,181k	_370,341k	_{p=0.689 n=6}
_{Parse Time}	_{2.76s (± 0.75%)}	_{2.77s (± 0.53%)}	_~	_2.75s	_2.79s	_{p=0.803 n=6}
_{Bind Time}	_{1.58s (± 0.78%)}	_{1.57s (± 0.67%)}	_~	_1.55s	_1.58s	_{p=0.183 n=6}
_{Check Time}	_{15.75s (± 0.29%)}	_{15.73s (± 0.28%)}	_~	_15.69s	_15.80s	_{p=0.808 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.08s (± 0.26%)}	_{20.07s (± 0.20%)}	_~	_20.01s	_20.13s	_{p=0.687 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₁	₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,044,200	_3,044,200	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,052,654	_1,052,654	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,152,336k (± 0.00%)}	_{3,152,342k (± 0.00%)}	_~	_3,152,287k	_3,152,421k	_{p=1.000 n=6}
_{Parse Time}	_{13.80s (± 0.25%)}	_{13.84s (± 0.53%)}	_~	_13.75s	_13.96s	_{p=0.258 n=6}
_{Bind Time}	_{4.36s (± 0.19%)}	_{4.35s (± 0.43%)}	_~	_4.32s	_4.37s	_{p=1.000 n=6}
_{Check Time}	_{81.35s (± 0.37%)}	_{81.31s (± 0.45%)}	_~	_80.85s	_81.84s	_{p=0.630 n=6}
_{Emit Time}	_{22.07s (± 0.21%)}	_{22.11s (± 0.27%)}	_~	_22.02s	_22.19s	_{p=0.226 n=6}
_{Total Time}	_{121.57s (± 0.24%)}	_{121.62s (± 0.32%)}	_~	_121.06s	_122.12s	_{p=0.689 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_277,022	_277,022	_~	_~	_~	_{p=1.000 n=6}
_Types	_112,817	_112,817	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{426,785k (± 0.03%)}	_{426,786k (± 0.02%)}	_~	_426,650k	_426,846k	_{p=0.936 n=6}
_{Parse Time}	_{4.89s (± 0.59%)}	_{4.90s (± 0.30%)}	_~	_4.88s	_4.92s	_{p=0.629 n=6}
_{Bind Time}	_{2.15s (± 1.43%)}	_{2.13s (± 1.20%)}	_~	_2.10s	_2.16s	_{p=0.373 n=6}
_{Check Time}	_{21.77s (± 0.44%)}	_{21.72s (± 0.38%)}	_~	_21.58s	_21.81s	_{p=0.521 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{28.81s (± 0.26%)}	_{28.76s (± 0.28%)}	_~	_28.61s	_28.85s	_{p=0.199 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_539,317	_539,317	_~	_~	_~	_{p=1.000 n=6}
_Types	_178,997	_178,997	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{484,165k (± 0.02%)}	_{484,033k (± 0.02%)}	_~	_483,915k	_484,183k	_{p=0.128 n=6}
_{Parse Time}	_{4.25s (± 0.24%)}	_{4.26s (± 0.50%)}	_~	_4.22s	_4.28s	_{p=0.359 n=6}
_{Bind Time}	_{1.55s (± 0.63%)}	_{1.55s (± 0.33%)}	_~	_1.54s	_1.55s	_{p=0.348 n=6}
_{Check Time}	_{22.62s (± 0.38%)}	_{22.57s (± 0.31%)}	_~	_22.46s	_22.65s	_{p=0.423 n=6}
_{Emit Time}	_{0.00s (±244.70%)}	_0.00s	_~	_~	_~	_{p=0.405 n=6}
_{Total Time}	_{28.43s (± 0.24%)}	_{28.37s (± 0.27%)}	_~	_28.23s	_28.43s	_{p=0.517 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

Andarist · 2024-09-12T11:22:22Z

@jakebailey, I have made local WIP improvements for nested patterns. However, there are some pre-existing inconsistencies between array and binding patterns. It would be great if we could establish the desired behavior as that heavily impacts how I should implement this. Let's take a look at this (TS 5.5 playground):

function testObj({ a, b, c = 1 } = { a: 2 }) {} // implicit any on `b`, ok

testObj({ a: 3 }); // error, missing `b`

function testArr([a, b, c = 1] = [2]) {} // implicit any on `b`, ok

testArr([3]); // no error

As we can see above, the optionality is different for those members with inferred implicit anys

It might be easier to make those properties optional if we don't want to revert parts of #59183 . the parts mentioned there as "strictly not necessary for the fix"

Andarist · 2024-09-13T11:18:05Z

src/compiler/types.ts

@@ -6010,7 +6010,6 @@ export interface SymbolLinks {
    exportsChecked?: boolean;                   // True if exports of external module have been checked
    typeParametersChecked?: boolean;            // True if type parameters of merged class and interface declarations have been checked.
    isDeclarationWithCollidingName?: boolean;   // True if symbol is block scoped redeclaration
-    bindingElement?: BindingElement;            // Binding element associated with property symbol


This one has been introduced in #4598 but its usage was removed in #59183

typescript-bot · 2024-09-13T11:29:57Z

Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page.

Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up.

Andarist · 2024-09-13T12:13:28Z

tests/baselines/reference/api/typescript.d.ts

@@ -8750,7 +8750,6 @@ declare namespace ts {
    function isJSDocCommentContainingNode(node: Node): boolean;
    function isSetAccessor(node: Node): node is SetAccessorDeclaration;
    function isGetAccessor(node: Node): node is GetAccessorDeclaration;
-    /** True if has initializer node attached to it. */


this one was copied over from an internal function declared above it, I don't think this comment is true as it made much more sense for the other function

Andarist · 2024-09-14T07:31:38Z

I pushed out changes to make those members with inferred implicit anys optional. Today they must be optional because the initializer's type is no longer "padded" (since #59183 ).

Given this example:

// @strict: true
function test({ a } = {}) {}

We get {} as the initializer's type and the initializer's type is checked if it's assignable to the parameter type. So if we infer { a: any } we get 2 errors:

an implicit any is reported on the a binding element
we get an error that {} is missing a required a property

This doesn't feel right. So I've decided to make those implicit anys optional. This allows the non-padded initializer's type to stay assignable to the padded parameter type.

Based on my previous comment I concluded that array and binding patterns were inconsistent and that it would be nice ot unify their behaviors. However, in the process of working on this, I discovered #4598 and the description of this PR indicates that they were not even meant to behave identically. This was in 2015 though, perhaps some adjustments could be made today.

Either way, to fix the reported problem we can:

make those implicit anys optional
pad the initializer type based on the padded parameter type (I dont like this at all ;p)
bring back padding in checkObjectLiteral so the initializer's type would have those properties. This would essentially revert a part of Fix circularity errors in intra-binding-pattern references #59183 . Note that in this situation... the initializer's type here would be { a: any } (and it was that in 5.5!), despite not having the a property
adjust how the initializer is checked against the padded parameter type. I'm not sure how exactly this would work since it's just using a regular assignability check today, so this would have to be a more involved change.

jakebailey · 2024-09-16T20:31:35Z

PR was changed, so rerun

@typescript-bot test it

typescript-bot · 2024-09-16T20:31:38Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	👀 Results
`user test this`	✅ Started	👀 Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-09-16T21:13:18Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{194,197k (± 1.03%)}	_{194,815k (± 0.96%)}	_~	_192,401k	_196,092k	_{p=0.575 n=6}
_{Parse Time}	_{1.58s (± 1.23%)}	_{1.57s (± 1.11%)}	_~	_1.54s	_1.59s	_{p=0.511 n=6}
_{Bind Time}	_{0.85s (± 0.64%)}	_{0.85s (± 0.98%)}	_~	_0.85s	_0.87s	_{p=0.855 n=6}
_{Check Time}	_{11.35s (± 0.45%)}	_{11.38s (± 0.19%)}	_~	_11.35s	_11.41s	_{p=0.335 n=6}
_{Emit Time}	_{3.24s (± 0.45%)}	_{3.24s (± 0.72%)}	_~	_3.21s	_3.27s	_{p=0.570 n=6}
_{Total Time}	_{17.03s (± 0.35%)}	_{17.05s (± 0.13%)}	_~	_17.03s	_17.08s	_{p=0.467 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₇	₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_945,753	_945,753	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,067	_410,067	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,222,769k (± 0.00%)}	_{1,222,730k (± 0.00%)}	_{-39k (- 0.00%)}	_1,222,688k	_1,222,759k	_{p=0.020 n=6}
_{Parse Time}	_{6.61s (± 0.41%)}	_{6.67s (± 0.13%)}	_{+0.06s (+ 0.86%)}	_6.66s	_6.68s	_{p=0.005 n=6}
_{Bind Time}	_{1.87s (± 0.29%)}	_{1.86s (± 0.22%)}	_~	_1.86s	_1.87s	_{p=0.282 n=6}
_{Check Time}	_{31.23s (± 0.37%)}	_{31.19s (± 0.64%)}	_~	_30.87s	_31.46s	_{p=0.873 n=6}
_{Emit Time}	_{15.05s (± 0.82%)}	_{15.05s (± 0.46%)}	_~	_14.95s	_15.12s	_{p=0.873 n=6}
_{Total Time}	_{54.75s (± 0.38%)}	_{54.77s (± 0.43%)}	_~	_54.35s	_54.97s	_{p=0.688 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,520,527	_2,520,527	_~	_~	_~	_{p=1.000 n=6}
_Types	_935,974	_935,976	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,350,364k (± 0.00%)}	_{2,350,385k (± 0.00%)}	_~	_2,350,318k	_2,350,415k	_{p=0.521 n=6}
_{Parse Time}	_{9.29s (± 0.32%)}	_{9.30s (± 0.16%)}	_~	_9.27s	_9.31s	_{p=0.806 n=6}
_{Bind Time}	_{2.14s (± 0.66%)}	_{2.14s (± 0.35%)}	_~	_2.13s	_2.15s	_{p=0.867 n=6}
_{Check Time}	_{73.11s (± 0.49%)}	_{73.04s (± 0.53%)}	_~	_72.55s	_73.57s	_{p=0.689 n=6}
_{Emit Time}	_{0.28s (± 1.45%)}	_{0.27s (± 3.62%)}	_~	_0.26s	_0.28s	_{p=0.056 n=6}
_{Total Time}	_{84.82s (± 0.46%)}	_{84.75s (± 0.44%)}	_~	_84.30s	_85.28s	_{p=0.936 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,245,952	_1,245,953	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_264,213	_264,218	_{+5 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,398,214k (± 0.04%)}	_{2,398,089k (± 0.04%)}	_~	_2,397,095k	_2,399,638k	_{p=0.936 n=6}
_{Parse Time}	_{7.63s (± 0.53%)}	_{7.65s (± 0.59%)}	_~	_7.59s	_7.72s	_{p=0.688 n=6}
_{Bind Time}	_{2.80s (± 0.58%)}	_{2.81s (± 0.65%)}	_~	_2.79s	_2.83s	_{p=0.226 n=6}
_{Check Time}	_{51.07s (± 0.61%)}	_{51.12s (± 0.84%)}	_~	_50.34s	_51.61s	_{p=0.575 n=6}
_{Emit Time}	_{4.53s (± 4.29%)}	_{4.45s (± 3.01%)}	_~	_4.32s	_4.70s	_{p=0.575 n=6}
_{Total Time}	_{66.05s (± 0.36%)}	_{66.04s (± 0.44%)}	_~	_65.49s	_66.34s	_{p=0.298 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,245,952	_1,245,953	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_264,213	_264,218	_{+5 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,471,963k (± 0.02%)}	_{2,472,767k (± 0.02%)}	_~	_2,472,185k	_2,473,503k	_{p=0.066 n=6}
_{Parse Time}	_{5.26s (± 1.05%)}	_{5.27s (± 0.68%)}	_~	_5.21s	_5.31s	_{p=0.748 n=6}
_{Bind Time}	_{1.71s (± 0.71%)}	_{1.71s (± 0.52%)}	_~	_1.70s	_1.72s	_{p=0.676 n=6}
_{Check Time}	_{35.24s (± 0.74%)}	_{35.13s (± 0.15%)}	_~	_35.08s	_35.23s	_{p=0.575 n=6}
_{Emit Time}	_{3.12s (± 3.12%)}	_{3.07s (± 5.48%)}	_~	_2.95s	_3.40s	_{p=0.230 n=6}
_{Total Time}	_{45.36s (± 0.57%)}	_{45.19s (± 0.39%)}	_~	_45.04s	_45.51s	_{p=0.230 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_259,885	_259,897	_{+12 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_106,140	_106,145	_{+5 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{435,592k (± 0.02%)}	_{435,656k (± 0.02%)}	_~	_435,564k	_435,750k	_{p=0.173 n=6}
_{Parse Time}	_{4.26s (± 0.46%)}	_{4.25s (± 0.68%)}	_~	_4.20s	_4.28s	_{p=0.466 n=6}
_{Bind Time}	_{1.60s (± 1.63%)}	_{1.60s (± 0.51%)}	_~	_1.59s	_1.61s	_{p=0.739 n=6}
_{Check Time}	_{22.42s (± 0.45%)}	_{22.47s (± 0.34%)}	_~	_22.36s	_22.58s	_{p=0.296 n=6}
_{Emit Time}	_{1.87s (± 1.30%)}	_{1.85s (± 0.63%)}	_~	_1.83s	_1.86s	_{p=0.250 n=6}
_{Total Time}	_{30.14s (± 0.42%)}	_{30.17s (± 0.30%)}	_~	_30.04s	_30.28s	_{p=0.688 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₆₈	₆₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,018	_225,018	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,249	_94,249	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{370,264k (± 0.02%)}	_{370,307k (± 0.02%)}	_~	_370,210k	_370,442k	_{p=0.689 n=6}
_{Parse Time}	_{2.76s (± 0.96%)}	_{2.76s (± 0.77%)}	_~	_2.72s	_2.78s	_{p=1.000 n=6}
_{Bind Time}	_{1.57s (± 1.63%)}	_{1.57s (± 0.66%)}	_~	_1.56s	_1.59s	_{p=1.000 n=6}
_{Check Time}	_{15.78s (± 0.44%)}	_{15.73s (± 0.35%)}	_~	_15.64s	_15.80s	_{p=0.469 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.11s (± 0.42%)}	_{20.07s (± 0.36%)}	_~	_19.94s	_20.15s	_{p=0.688 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₁	₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,067,616	_3,067,616	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,059,253	_1,059,253	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,173,088k (± 0.00%)}	_{3,173,062k (± 0.00%)}	_~	_3,173,001k	_3,173,111k	_{p=0.378 n=6}
_{Parse Time}	_{11.65s (± 0.26%)}	_{11.66s (± 0.30%)}	_~	_11.61s	_11.72s	_{p=0.412 n=6}
_{Bind Time}	_{3.65s (± 0.29%)}	_{3.64s (± 0.14%)}	_~	_3.64s	_3.65s	_{p=0.794 n=6}
_{Check Time}	_{70.56s (± 0.34%)}	_{70.62s (± 0.30%)}	_~	_70.42s	_70.90s	_{p=0.810 n=6}
_{Emit Time}	_{18.81s (± 0.41%)}	_{18.75s (± 0.46%)}	_~	_18.63s	_18.89s	_{p=0.298 n=6}
_{Total Time}	_{104.65s (± 0.19%)}	_{104.67s (± 0.13%)}	_~	_104.46s	_104.83s	_{p=1.000 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_277,156	_277,156	_~	_~	_~	_{p=1.000 n=6}
_Types	_112,946	_112,946	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{426,866k (± 0.01%)}	_{426,875k (± 0.01%)}	_~	_426,827k	_426,925k	_{p=0.575 n=6}
_{Parse Time}	_{3.94s (± 0.30%)}	_{3.95s (± 0.41%)}	_~	_3.94s	_3.98s	_{p=0.157 n=6}
_{Bind Time}	_{1.72s (± 0.70%)}	_{1.71s (± 0.71%)}	_~	_1.70s	_1.73s	_{p=0.680 n=6}
_{Check Time}	_{17.58s (± 0.16%)}	_{17.59s (± 0.37%)}	_~	_17.50s	_17.68s	_{p=0.688 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{23.23s (± 0.10%)}	_{23.26s (± 0.30%)}	_~	_23.15s	_23.32s	_{p=0.369 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_531,582	_531,582	_~	_~	_~	_{p=1.000 n=6}
_Types	_181,676	_181,676	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{463,680k (± 0.01%)}	_{463,729k (± 0.02%)}	_~	_463,639k	_463,898k	_{p=0.297 n=6}
_{Parse Time}	_{3.13s (± 0.49%)}	_{3.10s (± 0.81%)}	_~	_3.08s	_3.14s	_{p=0.089 n=6}
_{Bind Time}	_{1.11s (± 0.46%)}	_{1.11s (± 0.37%)}	_~	_1.11s	_1.12s	_{p=0.595 n=6}
_{Check Time}	_{18.24s (± 0.38%)}	_{18.17s (± 0.23%)}	_~	_18.10s	_18.21s	_{p=0.053 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.49s (± 0.32%)}	_{22.39s (± 0.21%)}	_{-0.10s (- 0.43%)}	_22.34s	_22.46s	_{p=0.024 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-09-16T21:17:35Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-09-16T21:30:24Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/59924/merge:

Something interesting changed - please have a look.

Details

effect

tsconfig.json

[NEW] error TS7031: Binding element 'contentLength' implicitly has an 'any' type.
- packages/platform/src/internal/httpClientRequest.ts#L534 in packages/platform/tsconfig.src.json
[MISSING] error TS2339: Property 'contentLength' does not exist on type '{ contentType?: string | undefined; }'.
- packages/platform/src/internal/httpClientRequest.ts#L534 in packages/platform/tsconfig.src.json

tsconfig.build.json

[NEW] error TS7031: Binding element 'contentLength' implicitly has an 'any' type.
- packages/platform/src/internal/httpClientRequest.ts#L534 in packages/platform/tsconfig.build.json
[MISSING] error TS2339: Property 'contentLength' does not exist on type '{ contentType?: string | undefined; }'.
- packages/platform/src/internal/httpClientRequest.ts#L534 in packages/platform/tsconfig.build.json

tsconfig.base.json

[NEW] error TS7031: Binding element 'contentLength' implicitly has an 'any' type.
- packages/platform/src/internal/httpClientRequest.ts#L534 in tsconfig.base.json
[MISSING] error TS2339: Property 'contentLength' does not exist on type '{ contentType?: string | undefined; }'.
- packages/platform/src/internal/httpClientRequest.ts#L534 in tsconfig.base.json

typescript-bot · 2024-09-16T22:45:17Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/59924/merge:

Something interesting changed - please have a look.

Details

apollographql/apollo-client

2 of 12 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS7031: Binding element 'newResolvers' implicitly has an 'any' type.
- src/testing/experimental/createTestSchema.ts#L79

honojs/hono

5 of 6 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS7031: Binding element 'children' implicitly has an 'any' type.
- src/helper/css/index.ts#L159

jhipster/generator-jhipster

tsconfig.spec.json

error TS2578: Unused '@ts-expect-error' directive.
- cli/cli.spec.mts#L103

Andarist · 2024-09-17T09:41:25Z

I believe the latest commit in my other PR addresses the issues above. So that other one would have to land before this one here

jakebailey · 2024-09-25T18:08:43Z

src/compiler/checker.ts

    function pushCachedContextualType(node: Expression) {
        pushContextualType(node, getContextualType(node, /*contextFlags*/ undefined), /*isCache*/ true);
    }

-    function pushContextualType(node: Expression, type: Type | undefined, isCache: boolean) {
+    function pushContextualType(node: Node, type: Type | undefined, isCache: boolean) {


Can this be a narrower type than just Node?

With this implementation, it could be Expression | BindingPattern | BindingElement if you'd prefer that.

2 extra notes that come to my mind now:

maybe I shouldn't be reusing the same contextualTypes stack for this and I should just introduce a new one? It seemed fine here to avoid creating a new but then reusing getContextualType wasn't possible so it's slightly weird now that I'm only using part of the existing pattern . Perhaps with a new context flag it would be possible but introducing getContextualPaddingType seemed easier

if this gets approved, it might be a good idea to explore expanding getContextualPaddingType with support for array patterns and using pushContextualType/popContextualType in padTupleType. Since this PR tries to address a regression in a backportable manner I refrained from doing this to avoid any new unforeseen behavioral changes

jakebailey · 2024-09-25T18:37:01Z

As we can see above, the optionality is different for those members with inferred implicit anys

It sure seems weird for that tuple case to pass, other than that maybe the type is inferred as number[]?

@typescript-bot pack this

typescript-bot · 2024-09-25T18:37:04Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`pack this`	✅ Started	✅ Results

typescript-bot · 2024-09-25T18:38:40Z

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/163708/artifacts?artifactName=tgz&fileId=13C5396EFAC74BF4DBA2370B55CEC3178967F52CE943CE2E29D34444B078FB1402&fileName=/typescript-5.7.0-insiders.20240925.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

Andarist · 2024-09-25T19:20:41Z

It sure seems weird for that tuple case to pass, other than that maybe the type is inferred as number[]?

I'm not sure which one is number[] there, this is the inferred signature I see there:

function testArr([a, b, c]?: [number, any?, (number | undefined)?]): void

jakebailey · 2024-09-25T19:21:53Z

Oh, I guess it could be undefined, yeah.

Andarist · 2024-09-27T15:06:07Z

Closing as per #59920 (comment)

Pad object literal types with implicit anys based on binding pattern …

c28ea26

…elements

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Sep 10, 2024

Andarist commented Sep 10, 2024

View reviewed changes

src/compiler/checker.ts Outdated Show resolved Hide resolved

Andarist mentioned this pull request Sep 10, 2024

Binding element incorrectly reported as having any type in JS with JSDoc starting with 5.6.2 #59936

Closed

Andarist added 3 commits September 13, 2024 12:33

Improve padded object types computed based on nested patterns

7dc8ef0

update tests

32217ae

remove unused bindingElement link

5bcd475

typescript-bot assigned jakebailey Sep 13, 2024

Andarist commented Sep 13, 2024

View reviewed changes

update baselines

9ca5c51

Andarist commented Sep 13, 2024

View reviewed changes

shitf test files

e468300

jakebailey requested a review from ahejlsberg September 24, 2024 22:47

jakebailey mentioned this pull request Sep 25, 2024

Only pad initializer types for parameters without annotations and contextual signatures #59975

Closed

jakebailey reviewed Sep 25, 2024

View reviewed changes

Andarist closed this Sep 27, 2024

sandersn removed this from PR Backlog Apr 22, 2025

Pad object literal types with implicit anys based on binding pattern elements #59924

Pad object literal types with implicit anys based on binding pattern elements #59924

Conversation

Andarist commented Sep 10, 2024

jakebailey commented Sep 10, 2024

typescript-bot commented Sep 10, 2024 • edited Loading

typescript-bot commented Sep 10, 2024

tsc

Andarist commented Sep 12, 2024 • edited Loading

Choose a reason for hiding this comment

typescript-bot commented Sep 13, 2024

Choose a reason for hiding this comment

Andarist commented Sep 14, 2024

jakebailey commented Sep 16, 2024

typescript-bot commented Sep 16, 2024 • edited Loading

typescript-bot commented Sep 16, 2024

tsc

typescript-bot commented Sep 16, 2024

typescript-bot commented Sep 16, 2024

typescript-bot commented Sep 16, 2024

Andarist commented Sep 17, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jakebailey commented Sep 25, 2024

typescript-bot commented Sep 25, 2024 • edited Loading

typescript-bot commented Sep 25, 2024 • edited Loading

Andarist commented Sep 25, 2024

jakebailey commented Sep 25, 2024

Andarist commented Sep 27, 2024

typescript-bot commented Sep 10, 2024 •

edited

Loading

Andarist commented Sep 12, 2024 •

edited

Loading

typescript-bot commented Sep 16, 2024 •

edited

Loading

typescript-bot commented Sep 25, 2024 •

edited

Loading

typescript-bot commented Sep 25, 2024 •

edited

Loading