add excess property checks to spread objects defined inline #59277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
|
@typescript-bot test it |
|
Hey @iisaduan, the results of running the DT tests are ready. Everything looks the same! |
|
@iisaduan Here are the results of running the user tests with tsc comparing Something interesting changed - please have a look. Details
|
|
@iisaduan Here they are:
tscComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
@iisaduan Here are the results of running the top 400 repos with tsc comparing Something interesting changed - please have a look. Details
|
|
@iisaduan Here are some more interesting changes from running the top 400 repos suite Details
|
Closed
Andarist
reviewed
Jul 15, 2024
|
@typescript-bot test top400 |
|
@iisaduan Here are the results of running the user tests with tsc comparing Something interesting changed - please have a look. Details
|
|
@iisaduan Here are the results of running the top 400 repos with tsc comparing Something interesting changed - please have a look. Details
|
iisaduan
changed the title
User Test analysisazure-sdk
This might be a param that was not generated correctly. It might be the case that defining import { GeneratedClientOptionalParams } from './generated';
const internalPipelineOptions: GeneratedClientOptionalParams = {
...this.clientOptions,
...{
apiVersion: this.apiVersion,
loggingOptions: {
additionalAllowedHeaderNames: this.clientOptions?.loggingOptions?.additionalAllowedHeaderNames,
additionalAllowedQueryParameters: this.clientOptions?.loggingOptions?.additionalAllowedQueryParameters,
logger: logger.info,
},
},
...(isTokenCredential(this.credential)
? {
credential: this.credential,
credentialScopes: ["https://webpubsub.azure.com/.default"],
}
: {}),
}; |
Top 400 analysisdubinc/dub and noodle-run/noodleThese are errors on the same FaridSafi/react-native-gifted-chatThis is on an element in function Composer(): React.ReactElement {
return (
<TextInput
style={[
styles.textInput,
textInputStyle,
{ // error
height: composerHeight,
...Platform.select({
web: {
outlineWidth: 0,
outlineColor: 'transparent',
outlineOffset: 0,
},
}),
},
]}
{...textInputProps}
/>
)
}labring/FastGPTexcess property on the value a record object called vscodeExcess properties in types used for options:
radix-ui/primativesEach of these are in react-bootstrap/react-bootstrapExcess property in a style prop. headlessuiExcess property an object that is a function param, and the function uses the object as |
|
Changed some behavior (specifically: decided on points 2 and 3 in the PR description) based on the test results above. @typescript-bot test top400 |
|
Hey @iisaduan, the results of running the DT tests are ready. Everything looks the same! |
|
@iisaduan Here are the results of running the user tests with tsc comparing Everything looks good! |
|
@iisaduan Here they are:
tscComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
tsserverComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
startupComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
@iisaduan Here are the results of running the top 400 repos with tsc comparing Something interesting changed - please have a look. Details
|
|
@iisaduan |
|
Glad to hear that this would be useful! If there are other cases that you'd like to have checked, please let me know, and I can look into it when I start up on this again. The current status of this PR is that the check is inconsistent because of the way we get properties from union types, so some simple/reasonable cases that should be checked don't get checked. Example: const definedObj = { a: 1 } ;
const x: { a: 1 } = { ...( someBool ? definedObj : { b: 1 }) } // should error on `b`, but currently does notIn some cases, the order of the property definitions in the object will change whether it's checked or not. I spent some time looking into other ways to resolve property definitions (that also isn't slow), but I haven't had the chance to follow through completely |
|
I've had bugs in production due to this longstanding TypeScript issue. I'm really excited to see where this will go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39998
This PR adds EPC to a property
xfrom spread objects ifxis defined is defined inlineHasExpressionInitializeror a return statementJsxOpeningLikeElementExamples
1- Checks only occur on spreads defined inline. Mostly, this means
xis not defined in a variable that is being spread.We now also check conditional spreads if defined inline:
The tests also show that this check works with
satisfies.2-
3- This check is blocked when the parent object is within a JSX element. For example, a case that was hit in an earlier iteration of this PR had an error in an object spread and defined within the attributes of a JSX element.
The reasoning for 2 & 3 stems from previous discussions (for example #29883), that adding more checks in function parameters or jsx props would cause a lot of errors in existing JSX. This was also reflected in the tests for the previous iterations of this PR.