Lock down computed names in object literals and classes under --isolatedDeclarations #58596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
jakebailey
reviewed
May 20, 2024
| @@ -351,7 +351,7 @@ export function createSyntacticTypeNodeBuilder(options: CompilerOptions, resolve | |||
| } | |||
| else if (prop.name.kind === SyntaxKind.ComputedPropertyName) { | |||
| const expression = prop.name.expression; | |||
| if (!isPrimitiveLiteralValue(expression, /*includeBigInt*/ false) && !isEntityNameExpression(expression)) { | |||
| if (!isPrimitiveLiteralValue(expression, /*includeBigInt*/ false)) { | |||
There was a problem hiding this comment.
There is also code in typeFromObjectLiteral that is not effectively unused. isNonNarrowedBindableName also probably becomes useless since we can now syntactically determine if the computed property is valid so it can probably be removed from the resolver.
|
@weswigham Also fixes #58533 |
jakebailey
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58490 - an error is now always emitted on computed names in classes and object literals under
--isolatedDeclarations. Workarounds and carve-outs for builtin symbols, some new syntactic form, or locally bound unique symbols are followups~cc @dragomirtitian